Skip to content

Conversation

c298lee
Copy link
Contributor

@c298lee c298lee commented Jan 27, 2025

Changes:

  • replaces @sentry/utils with @sentry/core
  • removes @sentry/types dependency
  • removes Sentry.metrics
  • replace transactionContext with samplingContext
  • replace urlEncode with stringify from query-string

@c298lee c298lee requested review from billyvg and chargome January 27, 2025 19:42
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4127 1 4126 0
View the top 1 failed tests by shortest run time
Docs Search Modal can open help search modal
Stack Traces | 0.091s run time
TypeError: hoistNonReactStatics.default is not a function
    at withProfiler (.../sentry/sentry/node_modules/@.../react/src/profiler.tsx:173:23)
    at Object.<anonymous> (.../app/components/loadingIndicator.tsx:54:58)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../forms/controls/selectControl.tsx:17:48)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../app/components/contextPickerModal.tsx:11:45)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../app/actionCreators/navigation.tsx:9:50)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../components/search/index.tsx:12:19)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../app/components/helpSearch.tsx:10:15)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../components/modals/helpSearchModal.tsx:10:42)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at .../app/actionCreators/modal.tsx:158:74
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at openHelpSearchModal (.../app/actionCreators/modal.tsx:158:15)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Jan 27, 2025

Bundle Report

Changes will increase total bundle size by 70.71kB (0.21%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 33.49MB 70.71kB (0.21%) ⬆️

@billyvg
Copy link
Member

billyvg commented Feb 3, 2025

superceded by #84258

@billyvg billyvg closed this Feb 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants