ref(aws-lambda-integration): Ensure correct node options for all layers #83633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
andreiborza
force-pushed
the
ab/improved-lambda-layer-node-options-checks
branch
from
062ba8a to
45c49db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83633 +/- ##
==========================================
+ Coverage 87.53% 87.59% +0.05%
==========================================
Files 9409 9491 +82
Lines 537867 538935 +1068
Branches 21179 21179
==========================================
+ Hits 470836 472094 +1258
+ Misses 66683 66493 -190
Partials 348 348 |
andreiborza
force-pushed
the
ab/improved-lambda-layer-node-options-checks
branch
from
45c49db to
1c0cae3
Compare
Previously, we only had one node lambda layer called `SentryNodeServerlessSDK`. With the `v8` major of the sentry-javascript SDKs a new layer for `v7` was published under `SentryNodeServerlessSDKv7` while the `v8` layer rolled over into `SentryNodeServerlessSDK`. With `v8` the `@sentry/serverless` package was removed (see: #70137) and a version check was added to the integration to update `NODE_OPTIONS` for the integration accordingly. The version check assumes the `SentryNodeServerlessSDK` name and only checks the ARN version which is not enough to identify a `v7` layer since the introduction of `SentryNodeServerlessSDKv7`. With `v9` we will stop updating the `SentryNodeServerlessSDK` and instead publish `SentryNodeServerlessSDKv9` exclusively, the integration has to ensure the correct `NODE_OPTIONS` are set depending on layer name and ARN version which this PR adds.
andreiborza
force-pushed
the
ab/improved-lambda-layer-node-options-checks
branch
from
1c0cae3 to
84e0187
Compare
iamrajjoshi
reviewed
Jan 18, 2025
Lms24
approved these changes
Jan 20, 2025
Yep, happened to work because of that. For the |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
…rs (#83633) Previously, we only had one node lambda layer called `SentryNodeServerlessSDK`. With the `v8` major of the sentry-javascript SDKs a new layer for `v7` was published under `SentryNodeServerlessSDKv7` while the `v8` layer rolled over into `SentryNodeServerlessSDK`. With `v8` the `@sentry/serverless` package was removed (see: #70137) and a version check was added to the integration to update `NODE_OPTIONS` for the integration accordingly. The version check assumes the `SentryNodeServerlessSDK` name and only checks the ARN version which is not enough to identify a `v7` layer since the introduction of `SentryNodeServerlessSDKv7`. With `v9` we will stop updating the `SentryNodeServerlessSDK` and instead publish `SentryNodeServerlessSDKv9` exclusively, the integration has to ensure the correct `NODE_OPTIONS` are set depending on layer name and ARN version which this PR adds. Closes: #82646
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only had one node lambda layer called
SentryNodeServerlessSDK. With thev8major of the sentry-javascript SDKs a new layer forv7was published underSentryNodeServerlessSDKv7while thev8layer rolled over intoSentryNodeServerlessSDK.With
v8the@sentry/serverlesspackage was removed (see: #70137) and a version check was added to the integration to updateNODE_OPTIONSfor the integration accordingly. The version check assumes theSentryNodeServerlessSDKname and only checks the ARN version which is not enough to identify av7layer since the introduction ofSentryNodeServerlessSDKv7.With
v9we will stop updating theSentryNodeServerlessSDKand instead publishSentryNodeServerlessSDKv9exclusively, the integration has to ensure the correctNODE_OPTIONSare set depending on layer name and ARN version which this PR adds.Closes: #82646