feat(aws-lambda-integration): Prepare AWS lambda import for v8 SDK #70137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70137 +/- ##
==========================================
+ Coverage 78.85% 79.83% +0.98%
==========================================
Files 6507 6507
Lines 289584 289600 +16
Branches 49868 49869 +1
==========================================
+ Hits 228344 231197 +2853
+ Misses 60826 57990 -2836
+ Partials 414 413 -1
|
Lms24
approved these changes
May 3, 2024
| parsed_version = None | ||
|
|
||
| if ( | ||
| # Lambda layer version 235 was the latest version using `@sentry/serverless` before we switched to `@sentry/aws-serverless` |
There was a problem hiding this comment.
Reminds me that we once thought about creating some kind of public mapping between layer version and SDK version. We should probably revisit this
mydea
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the
@sentry/serverlesspackage for v8 of the JS SDK in favor of@sentry/aws-serverless, so we need to change how layer adds the-r(--require) flag to the Node.js process.We do this by changing the require statement based on the lambda layer version.