Skip to content

Conversation

@iker-barriocanal
Copy link
Contributor

#64346 removes the usage of the option, and this PR removes the option itself.

@iker-barriocanal iker-barriocanal requested a review from a team February 1, 2024 09:31
@iker-barriocanal iker-barriocanal self-assigned this Feb 1, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 1, 2024
Base automatically changed from iker/ref/rm-proj-spanattr to master February 6, 2024 12:44
@codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1153a9e) 81.36% compared to head (089b242) 81.28%.
Report is 3 commits behind head on master.

❗ Current head 089b242 differs from pull request most recent head 1f6af68. Consider uploading reports for the commit 1f6af68 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #64347      +/-   ##
==========================================
- Coverage   81.36%   81.28%   -0.08%     
==========================================
  Files        5237     5236       -1     
  Lines      231110   230473     -637     
  Branches    45342    45230     -112     
==========================================
- Hits       188033   187334     -699     
- Misses      37228    37298      +70     
+ Partials     5849     5841       -8     
Files Coverage Δ
src/sentry/models/options/project_option.py 97.43% <ø> (-0.04%) ⬇️
src/sentry/projectoptions/defaults.py 100.00% <ø> (ø)
src/sentry/relay/config/__init__.py 92.01% <ø> (-0.06%) ⬇️

... and 832 files with indirect coverage changes

@iker-barriocanal iker-barriocanal merged commit eb5765a into master Feb 6, 2024
@iker-barriocanal iker-barriocanal deleted the iker/ref/rm-spanattr-option branch February 6, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants