ref(proj-config): Remove span attributes #64346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64346 +/- ##
==========================================
+ Coverage 81.27% 81.30% +0.02%
==========================================
Files 5236 5236
Lines 230475 230309 -166
Branches 45230 45231 +1
==========================================
- Hits 187329 187247 -82
+ Misses 37306 37218 -88
- Partials 5840 5844 +4
|
jjbayer
requested changes
Feb 1, 2024
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
External Relays still require this field. So if we remove it here, we have to default it to true in internal Relays.
jjbayer
approved these changes
Feb 1, 2024
Exclusive time is now computed in non-renormalization, i.e. in Relay and not again in consumers.
iker-barriocanal
commented
Feb 1, 2024
Comment on lines
-233
to
-237
| assert actual == dict( | ||
| expected, | ||
| exclusive_time=exclusive_time, | ||
| hash=hash_values([expected["description"]]), | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Exclusive time is now computed in non-renormalization, i.e. in Relay and not again in consumers.
cmanallen
pushed a commit
that referenced
this pull request
Feb 7, 2024
Removes the unused `spanAttributes` in project configs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay PR: getsentry/relay#3038.
Removes the unused
spanAttributesin project configs.