fix(note email): Fix user avatar in note emails #59486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
commented
Nov 6, 2023
| def get_message_description(self, recipient: RpcActor, provider: ExternalProviders) -> Any: | ||
| return self.get_context()["text_description"] | ||
|
|
||
| def description_as_html(self, description: str, params: Mapping[str, Any]) -> SafeString: |
Member
Author
There was a problem hiding this comment.
description and params aren't actually needed here, but that's what the base function accepts. It's funny that we don't need description because that's the comment itself, but in the template (note.html) it's rendered from data.text.
scttcper
approved these changes
Nov 6, 2023
ceorourke
added a commit
that referenced
this pull request
Nov 7, 2023
A follow up to #59486 after I noticed the uploaded image avatars were looking rough. **Before** <img width="542" alt="Screenshot 2023-11-07 at 10 57 10 AM" src="https://github.com/getsentry/sentry/assets/29959063/336db04b-0843-4b29-a6bc-fcfa942128d6"> **After** <img width="544" alt="Screenshot 2023-11-07 at 10 54 46 AM" src="https://github.com/getsentry/sentry/assets/29959063/30c5edd9-ae1e-483f-9809-78bf67a138ac">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken user avatars in note emails - they currently always look like this with the question mark:
But after the fix they look like this:
(with a letter avatar)
(with an uploaded image avatar)
description_as_htmlworks well for most other activity (aka workflow) notifications because it expects to be passed a template string that it fills in and formats as HTML, but for note activity notifications (aka comments) there is no template string, it just needs to render the comment that was left on the issue. Also because of a different design, I needed to rewrite building up the avatar HTML because other workflow notifications (like resolving an issue, for example) render the user avatar and email address on the same line as the text and that's added in the template like this:but for note activity notifications, the title has the email address of the user who commented on the issue, and then the description needs to render only the user avatar and then the comment.
Fixes #58420