feat(replays): Save Replay>Network sort field/dir into the url #42795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Contributor
size-limit report 📦
|
billyvg
approved these changes
Jan 5, 2023
| DEFAULT_ASC | ||
| ); | ||
| const {getParamValue: getSortBy, setParamValue: setSortBy} = useUrlParams( | ||
| 's_n_by', |
Member
There was a problem hiding this comment.
These strings are kind of cryptic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit more than just saving the sort config into the url, most things related to the network table are refactored, but that's one of the few behavior changes.
Other behavior changes relate to the current/hover state of the table. I've made sure the hover state is works correctly when the table is sorted by the
startTimestampcolumn (in either direction). Also when the table is sorted by any other column, I've added a background on hover, so it's easier to see what row you're looking at (there is no hoverTime border).I also refactored to create
<NetworkTableCell>, which is similar to<NetworkHeaderCell>i guess. Inside of there I cleaned up some things, mostly converting that array of react elements into an array of element-factories; and also looking at the css for background-color, border, and color props of each row.Fixes #38948