feat(replays): Implement isHovered states for DOM and Network tabs #42558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Contributor
size-limit report 📦
|
ryan953
commented
Dec 21, 2022
| (item: Crumb) => { | ||
| (item: Crumb | NetworkSpan) => { | ||
| if (startTimestampMs) { | ||
| setCurrentHoverTime(relativeTimeInMs(item.timestamp ?? '', startTimestampMs)); |
Member
Author
There was a problem hiding this comment.
double-checked and the timestamps are in the same format, so no conversion is needed here.
billyvg
approved these changes
Dec 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds logic to render isCurrent and isHovered lines in the DOM and Network tabs on the Replay Details page.
There's also some cleanup of internal variables and things to make each tab more similar to each other.
The DOM tab has subtle ui changes, when you're hovering something the gray200 line appears. The network tab has some other changes to match what's in the latest figma: https://www.figma.com/file/OPFnT04z0uy8BEUms9OU4f/Specs%3A-Details-v3?node-id=604%3A17755&t=372r9SfA2ONS8RXR-0
Relates to #38948