ref(ui): Widen breadcrumbs category by 12px to support event.transaction #17243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
previously requested changes
Feb 25, 2020
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
This is probably not related here (or it might be)
But can we change the red warning sign to something less aggressive for transactions?
I feel like this should be shown like this, a transaction is never an error.
Member
|
Would you be OK with using one of these? Or should we design a new one specific for transactions? |
Member
|
Hmm not sure if we need a new icon but this one maybe? |
matejminar
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related SDK change: getsentry/sentry-javascript#2450
Before:
After:
