Skip to content

ref: Mark transactions as event.transaction in breadcrumbs #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2020
Merged

ref: Mark transactions as event.transaction in breadcrumbs #2450

merged 2 commits into from
Feb 26, 2020
+41 −4

Conversation

@kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Feb 24, 2020 •
edited
Loading

Necessary UI change: getsentry/sentry#17243

@kamilogorek kamilogorek mentioned this pull request Feb 24, 2020
Merged
lobsterkatie
lobsterkatie approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@getsentry-bot
Copy link
Contributor

getsentry-bot commented Feb 24, 2020 •
edited
Loading

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.707 kB) (ES6: 15.7266 kB)

Generated by 🚫 dangerJS against fa80210

@kamilogorek kamilogorek merged commit 2384854 into master Feb 26, 2020
@kamilogorek kamilogorek deleted the event-transaction-breadcrumbs branch February 26, 2020 13:01
This was referenced Mar 14, 2020
Merged
Merged
Merged
Closed
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamilogorek @getsentry-bot @lobsterkatie