Skip to content

Set SENTRY_CLI_EXECUTABLE if not set #5006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2025
Merged

Set SENTRY_CLI_EXECUTABLE if not set #5006

merged 3 commits into from
Jul 22, 2025

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jul 22, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.53 ms 1234.52 ms 8.99 ms
Size 3.19 MiB 4.38 MiB 1.19 MiB

Baseline results on branch: antonis/ios-rev2-check

Startup times

Revision Plain With Sentry Diff
9f2ab2b+dirty 1214.16 ms 1219.17 ms 5.00 ms

App size

Revision Plain With Sentry Diff
9f2ab2b+dirty 3.19 MiB 4.38 MiB 1.19 MiB

Previous results on branch: antonis/ios-rev2-check-2

Startup times

Revision Plain With Sentry Diff
8ceff7d+dirty 1221.41 ms 1227.33 ms 5.92 ms

App size

Revision Plain With Sentry Diff
8ceff7d+dirty 3.19 MiB 4.38 MiB 1.19 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 342.87 ms 403.82 ms 60.94 ms
Size 7.15 MiB 8.42 MiB 1.27 MiB

Baseline results on branch: antonis/ios-rev2-check

Startup times

Revision Plain With Sentry Diff
9f2ab2b+dirty 388.43 ms 436.54 ms 48.11 ms

App size

Revision Plain With Sentry Diff
9f2ab2b+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Previous results on branch: antonis/ios-rev2-check-2

Startup times

Revision Plain With Sentry Diff
8ceff7d+dirty 357.10 ms 340.02 ms -17.08 ms

App size

Revision Plain With Sentry Diff
8ceff7d+dirty 7.15 MiB 8.42 MiB 1.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.33 ms 1210.36 ms -5.96 ms
Size 2.63 MiB 3.81 MiB 1.18 MiB

Baseline results on branch: antonis/ios-rev2-check

Startup times

Revision Plain With Sentry Diff
9f2ab2b+dirty 1214.83 ms 1211.89 ms -2.94 ms

App size

Revision Plain With Sentry Diff
9f2ab2b+dirty 2.63 MiB 3.81 MiB 1.18 MiB

Previous results on branch: antonis/ios-rev2-check-2

Startup times

Revision Plain With Sentry Diff
8ceff7d+dirty 1227.34 ms 1230.12 ms 2.78 ms

App size

Revision Plain With Sentry Diff
8ceff7d+dirty 2.63 MiB 3.81 MiB 1.18 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 471.48 ms 464.98 ms -6.50 ms
Size 17.75 MiB 20.15 MiB 2.41 MiB

Baseline results on branch: antonis/ios-rev2-check

Startup times

Revision Plain With Sentry Diff
9f2ab2b 452.26 ms 444.20 ms -8.06 ms

App size

Revision Plain With Sentry Diff
9f2ab2b 17.75 MiB 20.15 MiB 2.41 MiB

@antonis antonis marked this pull request as ready for review July 22, 2025 16:56
@antonis antonis requested a review from lucas-zimerman as a code owner July 22, 2025 16:56
@antonis antonis merged commit a01a61c into antonis/ios-rev2-check Jul 22, 2025
55 of 56 checks passed
@antonis antonis deleted the antonis/ios-rev2-check-2 branch July 22, 2025 16:57
antonis added a commit that referenced this pull request Jul 22, 2025
@antonis
fix: Sentry CLI executable path resolution that was causing iOS build…
03e22d9 
… script failures (#5003)

* Assign SENTRY_CLI_EXECUTABLE

* Revert "Assign SENTRY_CLI_EXECUTABLE"

This reverts commit 068a7bc.

* Revert "Fix SDK Build when using PnPM (#4977)"

This reverts commit 4f13db0.

* Reapply "Fix SDK Build when using PnPM (#4977)"

This reverts commit 3f77d3b.

* Adds bin/sentry-cli in SENTRY_CLI_PACKAGE_PATH

* Set SENTRY_CLI_PACKAGE_PATH in sentry-xcode.sh

* Adds changelog

* Set SENTRY_CLI_EXECUTABLE if not set (#5006)

* Set SENTRY_CLI_EXECUTABLE if not set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis