fix: Sentry CLI executable path resolution that was causing iOS build script failures #5003

antonis · 2025-07-21T13:23:58Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Sets SENTRY_CLI_PACKAGE_PATH to point to /bin/sentry-cli

💡 Motivation and Context

This is a follow up to #4977 to fix the failing Test ios production REV2 tests

💚 How did you test it?

CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2025-07-21T13:36:18Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	404.26 ms	388.53 ms	-15.73 ms
Size	17.75 MiB	20.15 MiB	2.41 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`bd87539`	403.50 ms	395.47 ms	-8.03 ms
`9f14d9d`	443.69 ms	453.04 ms	9.35 ms
`368003b`	441.36 ms	435.04 ms	-6.32 ms
`f25ae46`	459.92 ms	451.78 ms	-8.14 ms
`c352c30`	331.98 ms	321.78 ms	-10.20 ms
`b4d6bde`	425.51 ms	417.37 ms	-8.14 ms
`f0b931f`	447.12 ms	430.32 ms	-16.80 ms
`071ae5c`	393.64 ms	406.60 ms	12.96 ms
`6715c24`	419.21 ms	416.43 ms	-2.78 ms
`d079998`	460.60 ms	459.56 ms	-1.05 ms

App size

Revision	Plain	With Sentry	Diff
`bd87539`	17.75 MiB	20.15 MiB	2.40 MiB
`9f14d9d`	17.75 MiB	20.15 MiB	2.41 MiB
`368003b`	17.75 MiB	20.15 MiB	2.41 MiB
`f25ae46`	17.75 MiB	20.15 MiB	2.40 MiB
`c352c30`	17.75 MiB	20.15 MiB	2.40 MiB
`b4d6bde`	17.75 MiB	20.15 MiB	2.40 MiB
`f0b931f`	17.75 MiB	20.15 MiB	2.41 MiB
`071ae5c`	17.75 MiB	20.15 MiB	2.41 MiB
`6715c24`	17.75 MiB	20.15 MiB	2.40 MiB
`d079998`	17.75 MiB	20.15 MiB	2.41 MiB

Previous results on branch: antonis/ios-rev2-check

Startup times

Revision	Plain	With Sentry	Diff
`9f2ab2b`	452.26 ms	444.20 ms	-8.06 ms

App size

Revision	Plain	With Sentry	Diff
`9f2ab2b`	17.75 MiB	20.15 MiB	2.41 MiB

github-actions · 2025-07-21T13:45:45Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	377.89 ms	403.85 ms	25.97 ms
Size	7.15 MiB	8.42 MiB	1.27 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9167f73`+dirty	372.49 ms	389.90 ms	17.41 ms
`398e5d0`+dirty	422.88 ms	444.98 ms	22.10 ms
`38a1af2`+dirty	421.38 ms	431.35 ms	9.97 ms
`b4d6bde`+dirty	390.51 ms	385.60 ms	-4.91 ms
`f76175c`+dirty	354.23 ms	378.20 ms	23.97 ms
`ed5d418`+dirty	364.69 ms	434.17 ms	69.48 ms
`f0b931f`+dirty	340.44 ms	412.62 ms	72.18 ms
`071ae5c`+dirty	342.42 ms	400.02 ms	57.60 ms
`c352c30`+dirty	396.83 ms	378.11 ms	-18.72 ms
`a3aad2b`+dirty	389.53 ms	436.76 ms	47.23 ms

App size

Revision	Plain	With Sentry	Diff
`9167f73`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`398e5d0`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`38a1af2`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`b4d6bde`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`f76175c`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`ed5d418`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`f0b931f`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`071ae5c`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`c352c30`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`a3aad2b`+dirty	7.15 MiB	8.42 MiB	1.26 MiB

Previous results on branch: antonis/ios-rev2-check

Startup times

Revision	Plain	With Sentry	Diff
`9f2ab2b`+dirty	388.43 ms	436.54 ms	48.11 ms

App size

Revision	Plain	With Sentry	Diff
`9f2ab2b`+dirty	7.15 MiB	8.42 MiB	1.27 MiB

github-actions · 2025-07-21T13:51:30Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1212.53 ms	1217.74 ms	5.21 ms
Size	2.63 MiB	3.81 MiB	1.18 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c5c2e71`+dirty	1231.91 ms	1235.06 ms	3.15 ms
`38a1af2`+dirty	1210.07 ms	1212.75 ms	2.68 ms
`f25ae46`+dirty	1230.92 ms	1228.98 ms	-1.94 ms
`1f1c420`+dirty	1216.77 ms	1214.48 ms	-2.29 ms
`f76175c`+dirty	1223.29 ms	1232.52 ms	9.23 ms
`ec2a485`+dirty	1219.72 ms	1224.66 ms	4.94 ms
`b4d6bde`+dirty	1223.22 ms	1243.56 ms	20.34 ms
`071ae5c`+dirty	1224.22 ms	1227.83 ms	3.61 ms
`c352c30`+dirty	1216.60 ms	1231.37 ms	14.77 ms
`9167f73`+dirty	1230.79 ms	1230.63 ms	-0.17 ms

App size

Revision	Plain	With Sentry	Diff
`c5c2e71`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`38a1af2`+dirty	2.63 MiB	3.79 MiB	1.15 MiB
`f25ae46`+dirty	2.63 MiB	3.80 MiB	1.17 MiB
`1f1c420`+dirty	2.63 MiB	3.77 MiB	1.14 MiB
`f76175c`+dirty	2.63 MiB	3.80 MiB	1.17 MiB
`ec2a485`+dirty	2.63 MiB	3.78 MiB	1.15 MiB
`b4d6bde`+dirty	2.63 MiB	3.77 MiB	1.14 MiB
`071ae5c`+dirty	2.63 MiB	3.80 MiB	1.17 MiB
`c352c30`+dirty	2.63 MiB	3.78 MiB	1.15 MiB
`9167f73`+dirty	2.63 MiB	3.79 MiB	1.15 MiB

Previous results on branch: antonis/ios-rev2-check

Startup times

Revision	Plain	With Sentry	Diff
`9f2ab2b`+dirty	1214.83 ms	1211.89 ms	-2.94 ms

App size

Revision	Plain	With Sentry	Diff
`9f2ab2b`+dirty	2.63 MiB	3.81 MiB	1.18 MiB

github-actions · 2025-07-21T14:03:27Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1231.43 ms	1239.71 ms	8.29 ms
Size	3.19 MiB	4.38 MiB	1.19 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c5c2e71`+dirty	1233.45 ms	1231.24 ms	-2.20 ms
`38a1af2`+dirty	1211.57 ms	1219.27 ms	7.70 ms
`f25ae46`+dirty	1241.73 ms	1239.10 ms	-2.63 ms
`f76175c`+dirty	1228.08 ms	1234.00 ms	5.92 ms
`df5da5d`+dirty	1226.82 ms	1234.88 ms	8.06 ms
`6e8a851`+dirty	1222.57 ms	1223.67 ms	1.10 ms
`071ae5c`+dirty	1206.47 ms	1210.30 ms	3.84 ms
`9167f73`+dirty	1219.47 ms	1234.39 ms	14.92 ms
`26286ef`+dirty	1207.33 ms	1202.27 ms	-5.06 ms
`ba41c2a`+dirty	1218.92 ms	1221.02 ms	2.10 ms

App size

Revision	Plain	With Sentry	Diff
`c5c2e71`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`38a1af2`+dirty	3.19 MiB	4.35 MiB	1.17 MiB
`f25ae46`+dirty	3.19 MiB	4.36 MiB	1.17 MiB
`f76175c`+dirty	3.19 MiB	4.36 MiB	1.17 MiB
`df5da5d`+dirty	3.19 MiB	4.35 MiB	1.17 MiB
`6e8a851`+dirty	3.19 MiB	4.35 MiB	1.17 MiB
`071ae5c`+dirty	3.19 MiB	4.36 MiB	1.18 MiB
`9167f73`+dirty	3.19 MiB	4.35 MiB	1.17 MiB
`26286ef`+dirty	3.19 MiB	4.36 MiB	1.17 MiB
`ba41c2a`+dirty	3.19 MiB	4.36 MiB	1.17 MiB

Previous results on branch: antonis/ios-rev2-check

Startup times

Revision	Plain	With Sentry	Diff
`9f2ab2b`+dirty	1214.16 ms	1219.17 ms	5.00 ms

App size

Revision	Plain	With Sentry	Diff
`9f2ab2b`+dirty	3.19 MiB	4.38 MiB	1.19 MiB

This reverts commit 068a7bc.

This reverts commit 4f13db0.

packages/core/scripts/sentry-xcode-debug-files.sh

This reverts commit 3f77d3b.

lucas-zimerman

LGTM!

* Set SENTRY_CLI_EXECUTABLE if not set

lucas-zimerman

LGTM! Take 2

Assign SENTRY_CLI_EXECUTABLE

068a7bc

antonis changed the title ~~Assign SENTRY_CLI_EXECUTABLE~~ DRAFT: Fix Failing Test ios production REV2 Jul 21, 2025

antonis added 3 commits July 22, 2025 09:31

Merge branch 'main' into antonis/ios-rev2-check

5488103

Revert "Assign SENTRY_CLI_EXECUTABLE"

4693494

This reverts commit 068a7bc.

Revert "Fix SDK Build when using PnPM (#4977)"

3f77d3b

This reverts commit 4f13db0.

lucas-zimerman reviewed Jul 22, 2025

View reviewed changes

packages/core/scripts/sentry-xcode-debug-files.sh Show resolved Hide resolved

lucas-zimerman reviewed Jul 22, 2025

View reviewed changes

packages/core/scripts/sentry-xcode-debug-files.sh Show resolved Hide resolved

antonis added 3 commits July 22, 2025 13:29

Reapply "Fix SDK Build when using PnPM (#4977)"

d58f3e7

This reverts commit 3f77d3b.

Adds bin/sentry-cli in SENTRY_CLI_PACKAGE_PATH

658c1b4

Set SENTRY_CLI_PACKAGE_PATH in sentry-xcode.sh

df6992b

antonis changed the title ~~DRAFT: Fix Failing Test ios production REV2~~ fix: Set SENTRY_CLI_PACKAGE_PATH to point to /bin/sentry-cli Jul 22, 2025

antonis changed the title ~~fix: Set SENTRY_CLI_PACKAGE_PATH to point to /bin/sentry-cli~~ fix: Sentry CLI executable path resolution that was causing iOS build script failures Jul 22, 2025

Adds changelog

e02d18f

antonis marked this pull request as ready for review July 22, 2025 11:27

antonis requested a review from lucas-zimerman July 22, 2025 11:28

lucas-zimerman approved these changes Jul 22, 2025

View reviewed changes

Set SENTRY_CLI_EXECUTABLE if not set (#5006)

a01a61c

* Set SENTRY_CLI_EXECUTABLE if not set

antonis requested a review from lucas-zimerman July 22, 2025 16:57

lucas-zimerman approved these changes Jul 22, 2025

View reviewed changes

antonis merged commit 03e22d9 into main Jul 22, 2025
129 of 133 checks passed

antonis deleted the antonis/ios-rev2-check branch July 22, 2025 18:40

Uh oh!

fix: Sentry CLI executable path resolution that was causing iOS build script failures #5003

fix: Sentry CLI executable path resolution that was causing iOS build script failures #5003

Uh oh!

Conversation

antonis commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/ios-rev2-check

Startup times

App size

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/ios-rev2-check

Startup times

App size

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/ios-rev2-check

Startup times

App size

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/ios-rev2-check

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Jul 21, 2025 •

edited

Loading

github-actions bot commented Jul 21, 2025 •

edited

Loading

github-actions bot commented Jul 21, 2025 •

edited

Loading

github-actions bot commented Jul 21, 2025 •

edited

Loading

github-actions bot commented Jul 21, 2025 •

edited

Loading