fix(feedback): Fixes accessibility issue on iOS #4739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Krystof Woldrich <[email protected]>
…clicdep # Conflicts: # packages/core/src/js/feedback/FeedbackWidgetManager.tsx
This was referenced Apr 9, 2025
26 tasks
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d9099fd | 474.07 ms | 499.67 ms | 25.60 ms |
| 86e56c7 | 425.94 ms | 417.94 ms | -8.00 ms |
| 5c55a87 | 437.32 ms | 451.11 ms | 13.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d9099fd | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 86e56c7 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 5c55a87 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Android (new) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
krystofwoldrich
approved these changes
Apr 9, 2025
iOS (new) Performance metrics 🚀
|
This was referenced Apr 9, 2025
Base automatically changed from
antonis/ref-feedback-cyclicdep
to
feedback-ui-2
April 14, 2025 14:39
# Conflicts: # packages/core/src/js/feedback/ScreenshotButton.tsx # packages/core/test/feedback/ScreenshotButton.test.tsx # packages/core/test/feedback/__snapshots__/FeedbackWidgetManager.test.tsx.snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Based on: ref(feedback): Extracts FeedbackWidgetProvider in a separate file
PR Chain:
📜 Description
Fixes accessibility issue on iOS
💡 Motivation and Context
See #4302 (comment)
💚 How did you test it?
Manual testing of both iOS and Android. An iOS recording below
accessibility-ios.mov
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps