-
-
Notifications
You must be signed in to change notification settings - Fork 354
feat(feedback): Theming #4677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): Theming #4677
Conversation
Co-authored-by: Krystof Woldrich <[email protected]>
|
Overall, it's looking good, but I've noticed some issues with customizing the theme. We should add tests to ensure that the correct values are applied when using custom styles and custom themes. |
…nis/feedback-theme # Conflicts: # CHANGELOG.md
…ct-Button # Conflicts: # CHANGELOG.md
…nis/feedback-theme # Conflicts: # CHANGELOG.md
|
Thank you for all your feedback @krystofwoldrich 🙇 This should be ready for another go. Note that I now also cover the dynamic theme changes on this PR with 7a331b6 as part of the refactoring discussed above.
I've added snapshot tests to cover this with 6c63d03 |
|
Looks and works great! Reacts to the changes live. However, in the tests, only the custom dark and light scheme is checked. Can you also add a test for the system theme option, to check that the correct scheme is used, and a test for the live change if possible? |
# Conflicts: # CHANGELOG.md # packages/core/src/js/feedback/FeedbackButton.tsx # packages/core/src/js/feedback/FeedbackWidget.styles.ts # packages/core/src/js/feedback/FeedbackWidgetManager.tsx # packages/core/src/js/feedback/integration.ts # packages/core/test/feedback/FeedbackButton.test.tsx # packages/core/test/feedback/FeedbackWidgetManager.test.tsx # packages/core/test/feedback/__snapshots__/FeedbackButton.test.tsx.snap
|
Thank you for your feedback @krystofwoldrich 🙇
Added test for the system theme option with ba98685 |
krystofwoldrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the extra tests!
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. -->⚠️ PR Chain: - #13512 - 👉 #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback widget theme documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4677 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <[email protected]> Co-authored-by: Krystof Woldrich <[email protected]>
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. -->⚠️ PR Chain: - #13512 - 👉 #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback widget theme documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4677 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <[email protected]> Co-authored-by: Krystof Woldrich <[email protected]>
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. -->⚠️ PR Chain: - #13512 - 👉 #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback widget theme documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4677 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <[email protected]> Co-authored-by: Krystof Woldrich <[email protected]>
📢 Type of change
Based on feat(feedback): Report a Bug button
PR Chain:
📜 Description
Adds theming options similar to JS
Demo Video
Screen.Recording.2025-03-28.at.3.42.32.PM.mov
💡 Motivation and Context
💚 How did you test it?
Sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps