Skip to content

feat(redis): Add db.system to redis db spans #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

feat(redis): Add db.system to redis db spans #2038

merged 1 commit into from
Apr 25, 2023

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Apr 25, 2023

Dependent on #2037

Extracted from #2035

This was referenced Apr 25, 2023
Closed
Closed
@AbhiPrasad AbhiPrasad self-assigned this Apr 25, 2023
@antonpirker antonpirker merged commit 727a3d1 into abhi-db-system-const Apr 25, 2023
@antonpirker antonpirker deleted the abhi-db-system-redis branch April 25, 2023 12:18
antonpirker pushed a commit that referenced this pull request Apr 25, 2023
@AbhiPrasad
Add db.system to redis and SQLAlchemy db spans (#2037, #2038, #2039)
f106906 
* Add `db.system` constant
* Add `db.system` data to redis db spans (#2038)
* Add `db.system` data to SQLAlchemy db spans (#2039)
@AbhiPrasad AbhiPrasad mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antonpirker antonpirker antonpirker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AbhiPrasad AbhiPrasad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhiPrasad @antonpirker