Skip to content

Conversation

@AbhiPrasad
Copy link
Member

ref getsentry/team-webplatform-meta#60

dependent on getsentry/develop#917

Add this information to span data field as db.system, matching OpenTelemetry's well known conventions.

For example, db.system of postgresql would indicate that it's a postgres database.

hub, self.cursor, sql, params, paramstyle="format", executemany=False
):
) as span:
vendor = connection.vendor
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this strategy doesn't work if you have multiple connections open, but not sure how common that is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Django it is common to have one connection to a read only replica of the database and one you use to change the data, so probably on bigger installations quite common.

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Apr 25, 2023

Splitting this up in favour of 4 PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants