Skip to content

Conversation

@buenaflor
Copy link
Contributor

Craft 1.2.1 will include the fix.

Can be merged as soon as 1.2.1 is released

@buenaflor buenaflor requested a review from marandaneto March 13, 2023 15:52
@buenaflor buenaflor marked this pull request as ready for review March 13, 2023 15:52
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the publish repo already picks up the latest version of craft, so it's fine to change this but you can also change it after being sure it works, otherwise you have to patch this for every craft patch.

@buenaflor buenaflor merged commit 574091e into main Mar 15, 2023
@buenaflor buenaflor deleted the chore/craft branch March 15, 2023 09:52
buenaflor added a commit that referenced this pull request Mar 15, 2023
buenaflor added a commit that referenced this pull request Apr 17, 2023
* bump cocoa sdk to 8.3.0 and add view hierarchy

* feat(craft): kmp configuration in .craft.yml (#54)

* add kmp configuration to .craft.yml

* change minVersion to 1.2.0

* release: 0.0.1-alpha.2

* bump craft minVersion to 1.2.1 (#55)

* change to cocoapods as source

* chore: update readme (#56)

* update sdk version

* update cocoa version

* add updateReadme task

* Format code

* surround with trycatch when reading the file

* Format code

* update podspec

* use latest placeholder and track cocoa version manually

* remove updateReadme from format workflow

* re-add make format

* replace placeholder

* update readme

* Update sentry-kotlin-multiplatform/sentry_kotlin_multiplatform.podspec

* Update .github/workflows/format.yml

---------

Co-authored-by: Sentry Github Bot <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>

* update sentry cocoa version in README

* update pospec and changelog

* bump cocoa version to 8.4.0 and use attachViewHierarchy on Android

---------

Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: Sentry Github Bot <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants