-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: view hierarchy #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| pod(Config.Libs.sentryCocoa) { | ||
| source = git("https://github.com/getsentry/sentry-cocoa.git") { | ||
| tag = Config.Libs.sentryCocoaVersion | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing the source to GH?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing through cocoapods directly did not resolve for 8.3.0 (not sure how in sync they are with gh releases) and I was trying to keep it close to sentry docs since they also use gh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be something else, Cocoapods and GH should have the same version, for every release.
https://cocoapods.org/pods/Sentry#changelog
Let's focus on releasing the current version instead of fixing this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turned out to be a local gradle cache error so using cocoapods still works as expected
* add kmp configuration to .craft.yml * change minVersion to 1.2.0
|
What's missing is updating the sentry cocoa version to 8.3.0 in the readme but will wait for #56 first |
* update sdk version * update cocoa version * add updateReadme task * Format code * surround with trycatch when reading the file * Format code * update podspec * use latest placeholder and track cocoa version manually * remove updateReadme from format workflow * re-add make format * replace placeholder * update readme * Update sentry-kotlin-multiplatform/sentry_kotlin_multiplatform.podspec * Update .github/workflows/format.yml --------- Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: Manoel Aranda Neto <[email protected]>
|
| /** Enables or disables the attach view hierarchy feature when an error happened. */ | ||
| public var attachViewHierarchy: Boolean = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a 2nd line that this is only for Android and iOS
Add view hierarchy option for Android and iOS. This requires bumping the Cocoa SDK version from
8.2.0->8.4.0Testing: