Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Mar 10, 2023

@buenaflor buenaflor requested a review from marandaneto March 10, 2023 13:26
Comment on lines 85 to 89
pod(Config.Libs.sentryCocoa) {
source = git("https://github.com/getsentry/sentry-cocoa.git") {
tag = Config.Libs.sentryCocoaVersion
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing the source to GH?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing through cocoapods directly did not resolve for 8.3.0 (not sure how in sync they are with gh releases) and I was trying to keep it close to sentry docs since they also use gh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be something else, Cocoapods and GH should have the same version, for every release.
https://cocoapods.org/pods/Sentry#changelog
Let's focus on releasing the current version instead of fixing this now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turned out to be a local gradle cache error so using cocoapods still works as expected

@buenaflor
Copy link
Contributor Author

What's missing is updating the sentry cocoa version to 8.3.0 in the readme but will wait for #56 first

buenaflor and others added 2 commits March 16, 2023 12:54
* update sdk version

* update cocoa version

* add updateReadme task

* Format code

* surround with trycatch when reading the file

* Format code

* update podspec

* use latest placeholder and track cocoa version manually

* remove updateReadme from format workflow

* re-add make format

* replace placeholder

* update readme

* Update sentry-kotlin-multiplatform/sentry_kotlin_multiplatform.podspec

* Update .github/workflows/format.yml

---------

Co-authored-by: Sentry Github Bot <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
@buenaflor buenaflor requested a review from marandaneto March 16, 2023 12:15
@buenaflor buenaflor marked this pull request as draft March 16, 2023 12:27
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cf1a1ec

@buenaflor buenaflor marked this pull request as ready for review April 17, 2023 10:52
Comment on lines 70 to 71
/** Enables or disables the attach view hierarchy feature when an error happened. */
public var attachViewHierarchy: Boolean = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a 2nd line that this is only for Android and iOS

@buenaflor buenaflor merged commit 8b4cab0 into main Apr 17, 2023
@buenaflor buenaflor deleted the feat/view-hierarchy branch April 17, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants