Skip to content

chore(e2e-tests): Use Node 18 for E2E tests. #8964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

chore(e2e-tests): Use Node 18 for E2E tests. #8964

merged 2 commits into from
Sep 7, 2023

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Sep 6, 2023 •
edited
Loading

Updated Node to v18 (LTS) on E2E tests.

This is needed to properly test Remix v2.

Ref: #8940

@onurtemizkan onurtemizkan force-pushed the onur/use-node-18-for-e2e-tests branch from 0056357 to e9c362b Compare September 7, 2023 09:57
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.37 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.27 KB (0%)
@sentry/browser - Webpack (gzipped) 21.87 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.9 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.21 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.2 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.84 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.12 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.77 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.1 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.39 KB (0%)
@sentry/react - Webpack (gzipped) 21.9 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.25 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.83 KB (0%)

@onurtemizkan onurtemizkan force-pushed the onur/use-node-18-for-e2e-tests branch 3 times, most recently from 8ac5ba7 to 5d740ac Compare September 7, 2023 10:59
@onurtemizkan onurtemizkan force-pushed the onur/use-node-18-for-e2e-tests branch from 2219676 to f993888 Compare September 7, 2023 11:28
@onurtemizkan onurtemizkan marked this pull request as ready for review September 7, 2023 11:49
AbhiPrasad
AbhiPrasad approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for extracting it out!

@AbhiPrasad AbhiPrasad merged commit eafe791 into develop Sep 7, 2023
@AbhiPrasad AbhiPrasad deleted the onur/use-node-18-for-e2e-tests branch September 7, 2023 12:32
@onurtemizkan onurtemizkan mentioned this pull request Sep 7, 2023
Merged
billyvg pushed a commit that referenced this pull request Sep 7, 2023
@onurtemizkan @billyvg
chore(e2e): Use Node 18 for E2E tests. (#8964)
235b539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan @AbhiPrasad