chore(e2e): Use Node 18 for E2E tests. (#8964)

onurtemizkan · web-flow · commit eafe791bad26 · 2023-09-07T08:32:36.000-04:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -818,7 +818,7 @@ jobs:
       - name: Set up Node
         uses: actions/setup-node@v3
         with:
-          node-version-file: 'package.json'
+          node-version-file: 'packages/e2e-tests/package.json'
       - name: Restore caches
         uses: ./.github/actions/restore-cache
         env:
@@ -833,7 +833,7 @@ jobs:
       - name: Get node version
         id: versions
         run: |
-          echo "echo node=$(jq -r '.volta.node' package.json)" >> $GITHUB_OUTPUT
+          echo "echo node=$(jq -r '.volta.node' packages/e2e-tests/package.json)" >> $GITHUB_OUTPUT
 
       - name: Validate Verdaccio
         run: yarn test:validate
diff --git a/packages/e2e-tests/Dockerfile.publish-packages b/packages/e2e-tests/Dockerfile.publish-packages
@@ -1,5 +1,5 @@
 # This Dockerfile exists for the purpose of using a specific node/npm version (ie. the same we use in CI) to run npm publish with
-ARG NODE_VERSION=16.19.0
+ARG NODE_VERSION=18.17.1
 FROM node:${NODE_VERSION}
 
 WORKDIR /sentry-javascript/packages/e2e-tests
diff --git a/packages/e2e-tests/package.json b/packages/e2e-tests/package.json
@@ -2,9 +2,6 @@
   "name": "@sentry-internal/e2e-tests",
   "version": "7.68.0",
   "license": "MIT",
-  "engines": {
-    "node": ">=10"
-  },
   "private": true,
   "scripts": {
     "fix": "run-s fix:eslint fix:prettier",
@@ -32,6 +29,7 @@
     "yaml": "2.2.2"
   },
   "volta": {
-    "extends": "../../package.json"
+    "node": "18.17.1",
+    "yarn": "1.22.19"
   }
 }
diff --git a/packages/e2e-tests/test-applications/create-next-app/package.json b/packages/e2e-tests/test-applications/create-next-app/package.json
@@ -25,7 +25,6 @@
     "@playwright/test": "^1.27.1"
   },
   "volta": {
-    "node": "16.19.0",
-    "yarn": "1.22.19"
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/e2e-tests/test-applications/create-next-app/playwright.config.ts b/packages/e2e-tests/test-applications/create-next-app/playwright.config.ts
@@ -1,6 +1,11 @@
 import type { PlaywrightTestConfig } from '@playwright/test';
 import { devices } from '@playwright/test';
 
+// Fix urls not resolving to localhost on Node v17+
+// See: https://github.com/axios/axios/issues/3821#issuecomment-1413727575
+import { setDefaultResultOrder } from 'dns';
+setDefaultResultOrder('ipv4first');
+
 const testEnv = process.env.TEST_ENV;
 
 if (!testEnv) {
diff --git a/packages/e2e-tests/test-applications/create-react-app/package.json b/packages/e2e-tests/test-applications/create-react-app/package.json
@@ -48,7 +48,6 @@
     ]
   },
   "volta": {
-    "node": "16.19.0",
-    "yarn": "1.22.19"
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/e2e-tests/test-applications/create-remix-app/package.json b/packages/e2e-tests/test-applications/create-remix-app/package.json
@@ -31,5 +31,8 @@
   },
   "engines": {
     "node": ">=14"
+  },
+  "volta": {
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/e2e-tests/test-applications/nextjs-app-dir/package.json b/packages/e2e-tests/test-applications/nextjs-app-dir/package.json
@@ -32,7 +32,6 @@
     "@sentry/utils": "latest || *"
   },
   "volta": {
-    "node": "16.19.0",
-    "yarn": "1.22.19"
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/e2e-tests/test-applications/nextjs-app-dir/playwright.config.ts b/packages/e2e-tests/test-applications/nextjs-app-dir/playwright.config.ts
@@ -1,6 +1,11 @@
 import type { PlaywrightTestConfig } from '@playwright/test';
 import { devices } from '@playwright/test';
 
+// Fix urls not resolving to localhost on Node v17+
+// See: https://github.com/axios/axios/issues/3821#issuecomment-1413727575
+import { setDefaultResultOrder } from 'dns';
+setDefaultResultOrder('ipv4first');
+
 const testEnv = process.env.TEST_ENV;
 
 if (!testEnv) {
diff --git a/packages/e2e-tests/test-applications/node-express-app/package.json b/packages/e2e-tests/test-applications/node-express-app/package.json
@@ -24,7 +24,6 @@
     "@playwright/test": "^1.27.1"
   },
   "volta": {
-    "node": "16.19.0",
-    "yarn": "1.22.19"
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/e2e-tests/test-applications/react-create-hash-router/package.json b/packages/e2e-tests/test-applications/react-create-hash-router/package.json
@@ -51,7 +51,6 @@
     "serve": "14.0.1"
   },
   "volta": {
-    "node": "16.19.0",
-    "yarn": "1.22.19"
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/package.json b/packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/package.json
@@ -51,7 +51,6 @@
     "serve": "14.0.1"
   },
   "volta": {
-    "node": "16.19.0",
-    "yarn": "1.22.19"
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/e2e-tests/test-applications/standard-frontend-react/package.json b/packages/e2e-tests/test-applications/standard-frontend-react/package.json
@@ -52,7 +52,6 @@
     "serve": "14.0.1"
   },
   "volta": {
-    "node": "16.19.0",
-    "yarn": "1.22.19"
+    "extends": "../../package.json"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@`
`25`	`25`	`"@playwright/test": "^1.27.1"`
`26`	`26`	`},`
`27`	`27`	`"volta": {`
`28`		`- "node": "16.19.0",`
`29`		`- "yarn": "1.22.19"`
	`28`	`+ "extends": "../../package.json"`
`30`	`29`	`}`
`31`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@`
`48`	`48`	`]`
`49`	`49`	`},`
`50`	`50`	`"volta": {`
`51`		`- "node": "16.19.0",`
`52`		`- "yarn": "1.22.19"`
	`51`	`+ "extends": "../../package.json"`
`53`	`52`	`}`
`54`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,5 +31,8 @@`
`31`	`31`	`},`
`32`	`32`	`"engines": {`
`33`	`33`	`"node": ">=14"`
	`34`	`+ },`
	`35`	`+ "volta": {`
	`36`	`+ "extends": "../../package.json"`
`34`	`37`	`}`
`35`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@`
`32`	`32`	`"@sentry/utils": "latest \|\| *"`
`33`	`33`	`},`
`34`	`34`	`"volta": {`
`35`		`- "node": "16.19.0",`
`36`		`- "yarn": "1.22.19"`
	`35`	`+ "extends": "../../package.json"`
`37`	`36`	`}`
`38`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`	`"@playwright/test": "^1.27.1"`
`25`	`25`	`},`
`26`	`26`	`"volta": {`
`27`		`- "node": "16.19.0",`
`28`		`- "yarn": "1.22.19"`
	`27`	`+ "extends": "../../package.json"`
`29`	`28`	`}`
`30`	`29`	`}`