Skip to content

ref(deprecate): Deprecate timestampWithMs #7878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2023
Merged

ref(deprecate): Deprecate timestampWithMs #7878

merged 2 commits into from
Apr 18, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 17, 2023

Depends on #7877 being merged first.

@mydea mydea requested a review from a team April 17, 2023 14:04
@mydea mydea self-assigned this Apr 17, 2023
@mydea mydea requested review from AbhiPrasad and lforst and removed request for a team April 17, 2023 14:04
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.04 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/browser - Webpack (minified) 69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.21 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.05 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.62 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.85 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 45.35 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 39.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 64.29 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 57.26 KB (+0.01% 🔺)

@mydea
ref(deprecation): Deprecate timestampWithMs
2fe2868 
Use `timestampInSeconds` instead.
@mydea mydea force-pushed the fn/deprecate-timestampWithMs branch from dd3d00a to 2fe2868 Compare April 17, 2023 15:29
@mydea mydea marked this pull request as ready for review April 17, 2023 15:29
@mydea mydea merged commit de51011 into develop Apr 18, 2023
@mydea mydea deleted the fn/deprecate-timestampWithMs branch April 18, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-javascript-sdks

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @AbhiPrasad