Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 17, 2023

Fixes a bug introduced in #7632 due to assuming timestampWithMs returns a timestamp in ms (which it does not do).

Also replaces all usage of timestampWithMs with timestampInSeconds.

Let's deprecate timestampWithMs in a follow up PR.

Let's deprecate `timestampWithMs` in a follow up PR.
@mydea mydea requested review from AbhiPrasad and Lms24 April 17, 2023 14:02
@mydea mydea self-assigned this Apr 17, 2023
@mydea mydea changed the title fix(tracing): Ensure we use s instead of ms for startTimestamp fix(tracing): Ensure we use s instead of ms for startTimestamp Apr 17, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.04 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.59 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/browser - Webpack (minified) 69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.21 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.05 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.62 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.85 KB (-0.02% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 45.35 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 39.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 64.29 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 57.26 KB (0%)

@mydea mydea merged commit e3313ad into develop Apr 17, 2023
@mydea mydea deleted the fn/fix-transaction-start branch April 17, 2023 15:29
@jeengbe
Copy link
Contributor

jeengbe commented May 3, 2023

assuming timestampWithMs returns a timestamp in ms (which it does not do).

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants