Skip to content

meta: Update changelog for 7.22.0 #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022
Merged

meta: Update changelog for 7.22.0 #6325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 7.22.0
Copy link
Member

@AbhiPrasad AbhiPrasad Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: this should just be a patch, the core feat is completely internal to us.

Copy link
Contributor Author

@lforst lforst Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're extending the API in two places. Adding an argument to recordDroppedEvent is definitely a change that forces a minor and the remix typing changes are also technically a minor.

A minor is just correct here.

Copy link
Contributor Author

@lforst lforst Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recordDroppedEvent is not completely internal to us. Users can pass that hook.

Copy link
Member

@AbhiPrasad AbhiPrasad Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are both fair points, but the general likelyhood of an external user using recordDroppedEvent is extremely low. I wouldn't try to follow semvar to that precisely, I would optimize for making sure that upgrades are easy as possible, and so patches >> minor. This also applies to the remix typing changes, it's just a bug fix.


- feat(core): Pass `event` as third argument to `recordDroppedEvent` (#6289)
- fix(nextjs): Apply Webpack configuration in dev mode (#6291)
- fix(react): Relax React Router 6 `RouteObject` typing. (#6274)
- fix(remix): Prevent crashes from failed `normalizeRemixRequest` calls. (#6296)
- fix(remix): Attempt to extract user IP from request headers. (#6263)
- fix(remix): Pass transaction name as route to `RequestData`. (#6276)

## 7.21.1

- fix(nextjs): Stop excluding `withSentryConfig` from serverless bundles (#6267)
Expand Down