Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Nov 29, 2022

No description provided.

@lforst lforst requested a review from AbhiPrasad November 29, 2022 10:50
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.54 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (0%)
@sentry/browser - Webpack (minified) 65.25 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (+0.01% 🔺)
@sentry/replay index.js 83.65 KB (-0.07% 🔽)
@sentry/replay - Webpack (gzipped + minified) 83.67 KB (-0.07% 🔽)
@sentry/replay - Webpack (minified) 272.53 KB (-0.06% 🔽)


- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 7.22.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: this should just be a patch, the core feat is completely internal to us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're extending the API in two places. Adding an argument to recordDroppedEvent is definitely a change that forces a minor and the remix typing changes are also technically a minor.

A minor is just correct here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recordDroppedEvent is not completely internal to us. Users can pass that hook.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are both fair points, but the general likelyhood of an external user using recordDroppedEvent is extremely low. I wouldn't try to follow semvar to that precisely, I would optimize for making sure that upgrades are easy as possible, and so patches >> minor. This also applies to the remix typing changes, it's just a bug fix.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing offline, let's make it a minor.

@lforst lforst merged commit 669bca2 into master Nov 29, 2022
@lforst lforst deleted the lforst-changelog-7.22.0 branch November 29, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants