fix(remix): Sourcemaps upload script is missing in the tarball #5356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add prepack script for Remix package and custom .npmignore
onurtemizkan
approved these changes
Jul 4, 2022
vladanpaunovic
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To upload source maps to Sentry, the Remix SDK includes a script that wraps around Sentry CLI to make uploading sourcemaps easier for our users. However, due to the way how we package our NPM tarballs, this script didn't make it into the Remix SDK tarball.
This PR adds the script to the tarball, which required the following changes:
prepack.tsscript which is invoked by the mainprepack.tsscript. This is similar to how we do it with the Gatsby SDK where - just as with Remix - we need to copy over additional files to thebuilddirectory that are not part of our other packages. The newly added files are:scripts/sentry-upload-sourcemaps.jsscripts/createRelease.js.npmignorewhich extends the root level.npmignorefile to not ignore thescriptsdirectory in thebuilddirectory.Fixes #5355