Skip to content

ref(tracing): Reduce metrics bundle size #5122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2022
Merged

ref(tracing): Reduce metrics bundle size #5122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bc8215
ref(tracing): Reduce metrics bundle size
AbhiPrasad May 17, 2022
8b6ecb0
reorg structure
AbhiPrasad May 19, 2022
a1a5323
Ignore some eslint errors
May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/tracing/src/browser/browsertracing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { startIdleTransaction } from '../hubextensions';
import { DEFAULT_FINAL_TIMEOUT, DEFAULT_IDLE_TIMEOUT } from '../idletransaction';
import { extractTraceparentData } from '../utils';
import { registerBackgroundTabDetection } from './backgroundtab';
import { MetricsInstrumentation } from './metrics';
import { addPerformanceEntries, startTrackingWebVitals } from './metrics';
import {
defaultRequestInstrumentationOptions,
instrumentOutgoingRequests,
Expand Down Expand Up @@ -126,8 +126,6 @@ export class BrowserTracing implements Integration {

private _getCurrentHub?: () => Hub;

private readonly _metrics: MetricsInstrumentation;

private readonly _emitOptionsWarning?: boolean;

public constructor(_options?: Partial<BrowserTracingOptions>) {
Expand All @@ -148,7 +146,7 @@ export class BrowserTracing implements Integration {
};

const { _metricOptions } = this.options;
this._metrics = new MetricsInstrumentation(_metricOptions && _metricOptions._reportAllChanges);
startTrackingWebVitals(_metricOptions && _metricOptions._reportAllChanges);
}

/**
Expand Down Expand Up @@ -235,7 +233,11 @@ export class BrowserTracing implements Integration {
{ location }, // for use in the tracesSampler
);
idleTransaction.registerBeforeFinishCallback(transaction => {
this._metrics.addPerformanceEntries(transaction);
addPerformanceEntries(transaction);
transaction.setTag(
'sentry_reportAllChanges',
Boolean(this.options._metricOptions && this.options._metricOptions._reportAllChanges),
);
});

return idleTransaction as Transaction;
Expand Down
Loading