ref(tracing): Reduce metrics bundle size #5122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
force-pushed
the
v7-abhi-metrics-refactor
branch
from
09a20c7 to
f8435cc
Compare
AbhiPrasad
requested review from
a team,
lforst and
lobsterkatie
and removed request for
a team
AbhiPrasad
force-pushed
the
v7-abhi-metrics-refactor
branch
from
f8435cc to
8b6ecb0
Compare
lforst
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces metrics bundle size by converting the
MetricsInstrumentationclass into a set of functions.The
MetricsInstrumentationclass constructor was turned into thestartTrackingWebVitalsfunction. The internal class state was turned into a set of global variables that get mutated.Resolves https://getsentry.atlassian.net/browse/WEB-816