fix(ember): Use ui category for span operations #4221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-fish
approved these changes
Dec 2, 2021
lobsterkatie
added a commit
that referenced
this pull request
Dec 3, 2021
Follow-up to #4221, which changed the names given to certain auto-generated spans, but missed changing them in tests.
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
As per the new spec in https://develop.sentry.dev/sdk/performance/span-operations/#js-frameworks, we now want to prefix our ember spans operations with `ui`.
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
Follow-up to #4221, which changed the names given to certain auto-generated spans, but missed changing them in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the new spec in https://develop.sentry.dev/sdk/performance/span-operations/#js-frameworks, we now want to prefix our ember spans operations with
ui.