Skip to content

Commit 111e1ff

Browse files
lobsterkatielobsterkatie
authored
fix(ember): Fix span names in tests (#4228)
Follow-up to #4221, which changed the names given to certain auto-generated spans, but missed changing them in tests.
1 parent 80b7471 commit 111e1ff

File tree

1 file changed

+52
-52
lines changed

1 file changed

+52
-52
lines changed

‎packages/ember/tests/acceptance/sentry-performance-test.js‎

Lines changed: 52 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ function assertSentryCall(assert, callNumber, options) {
3131
// FIXME: For some reason, the last `afterRender` and `destroy` run queue event are not always called.
3232
// This is not a blocker, but should be investigated and fixed, as this is the expected output.
3333
const lastSpan = event.spans[event.spans.length - 1];
34-
if (lastSpan === 'ember.runloop.afterRender | undefined') {
35-
event.spans.push('ember.runloop.destroy | undefined');
36-
} else if (lastSpan === 'ember.runloop.render | undefined') {
37-
event.spans.push('ember.runloop.afterRender | undefined', 'ember.runloop.destroy | undefined');
34+
if (lastSpan === 'ui.ember.runloop.afterRender | undefined') {
35+
event.spans.push('ui.ember.runloop.destroy | undefined');
36+
} else if (lastSpan === 'ui.ember.runloop.render | undefined') {
37+
event.spans.push('ui.ember.runloop.afterRender | undefined', 'ui.ember.runloop.destroy | undefined');
3838
}
3939

4040
assert.deepEqual(event.spans, options.spans, `Has correct spans`);
@@ -60,15 +60,15 @@ module('Acceptance | Sentry Transactions', function(hooks) {
6060
assertSentryTransactionCount(assert, 1);
6161
assertSentryCall(assert, 0, {
6262
spans: [
63-
'ember.transition | route:undefined -> route:tracing',
64-
'ember.component.render | component:link-to',
65-
'ember.component.render | component:link-to',
66-
'ember.component.render | component:test-section',
67-
'ember.runloop.actions | undefined',
68-
'ember.runloop.routerTransitions | undefined',
69-
'ember.runloop.render | undefined',
70-
'ember.runloop.afterRender | undefined',
71-
'ember.runloop.destroy | undefined',
63+
'ui.ember.transition | route:undefined -> route:tracing',
64+
'ui.ember.component.render | component:link-to',
65+
'ui.ember.component.render | component:link-to',
66+
'ui.ember.component.render | component:test-section',
67+
'ui.ember.runloop.actions | undefined',
68+
'ui.ember.runloop.routerTransitions | undefined',
69+
'ui.ember.runloop.render | undefined',
70+
'ui.ember.runloop.afterRender | undefined',
71+
'ui.ember.runloop.destroy | undefined',
7272
],
7373
transaction: 'route:tracing',
7474
tags: {
@@ -87,53 +87,53 @@ module('Acceptance | Sentry Transactions', function(hooks) {
8787
assertSentryTransactionCount(assert, 2);
8888
assertSentryCall(assert, 1, {
8989
spans: [
90-
'ember.transition | route:tracing -> route:slow-loading-route.index',
91-
'ember.component.render | component:link-to',
92-
'ember.component.render | component:link-to',
90+
'ui.ember.transition | route:tracing -> route:slow-loading-route.index',
91+
'ui.ember.component.render | component:link-to',
92+
'ui.ember.component.render | component:link-to',
9393
'ember.route.beforeModel | slow-loading-route',
94-
'ember.runloop.actions | undefined',
95-
'ember.runloop.routerTransitions | undefined',
96-
'ember.runloop.render | undefined',
97-
'ember.runloop.afterRender | undefined',
98-
'ember.runloop.destroy | undefined',
94+
'ui.ember.runloop.actions | undefined',
95+
'ui.ember.runloop.routerTransitions | undefined',
96+
'ui.ember.runloop.render | undefined',
97+
'ui.ember.runloop.afterRender | undefined',
98+
'ui.ember.runloop.destroy | undefined',
9999
'ember.route.model | slow-loading-route',
100-
'ember.runloop.actions | undefined',
101-
'ember.runloop.routerTransitions | undefined',
102-
'ember.runloop.render | undefined',
103-
'ember.runloop.afterRender | undefined',
104-
'ember.runloop.destroy | undefined',
100+
'ui.ember.runloop.actions | undefined',
101+
'ui.ember.runloop.routerTransitions | undefined',
102+
'ui.ember.runloop.render | undefined',
103+
'ui.ember.runloop.afterRender | undefined',
104+
'ui.ember.runloop.destroy | undefined',
105105
'ember.route.afterModel | slow-loading-route',
106-
'ember.runloop.actions | undefined',
107-
'ember.runloop.routerTransitions | undefined',
108-
'ember.component.render | component:link-to',
109-
'ember.component.render | component:link-to',
110-
'ember.runloop.render | undefined',
111-
'ember.runloop.afterRender | undefined',
112-
'ember.runloop.destroy | undefined',
106+
'ui.ember.runloop.actions | undefined',
107+
'ui.ember.runloop.routerTransitions | undefined',
108+
'ui.ember.component.render | component:link-to',
109+
'ui.ember.component.render | component:link-to',
110+
'ui.ember.runloop.render | undefined',
111+
'ui.ember.runloop.afterRender | undefined',
112+
'ui.ember.runloop.destroy | undefined',
113113
'ember.route.beforeModel | slow-loading-route.index',
114-
'ember.runloop.actions | undefined',
115-
'ember.runloop.routerTransitions | undefined',
116-
'ember.runloop.render | undefined',
117-
'ember.runloop.afterRender | undefined',
118-
'ember.runloop.destroy | undefined',
114+
'ui.ember.runloop.actions | undefined',
115+
'ui.ember.runloop.routerTransitions | undefined',
116+
'ui.ember.runloop.render | undefined',
117+
'ui.ember.runloop.afterRender | undefined',
118+
'ui.ember.runloop.destroy | undefined',
119119
'ember.route.model | slow-loading-route.index',
120-
'ember.runloop.actions | undefined',
121-
'ember.runloop.routerTransitions | undefined',
122-
'ember.runloop.render | undefined',
123-
'ember.runloop.afterRender | undefined',
124-
'ember.runloop.destroy | undefined',
120+
'ui.ember.runloop.actions | undefined',
121+
'ui.ember.runloop.routerTransitions | undefined',
122+
'ui.ember.runloop.render | undefined',
123+
'ui.ember.runloop.afterRender | undefined',
124+
'ui.ember.runloop.destroy | undefined',
125125
'ember.route.afterModel | slow-loading-route.index',
126-
'ember.runloop.actions | undefined',
126+
'ui.ember.runloop.actions | undefined',
127127
'ember.route.setupController | slow-loading-route',
128128
'ember.route.setupController | slow-loading-route.index',
129-
'ember.runloop.routerTransitions | undefined',
130-
'ember.component.render | component:link-to',
131-
'ember.component.render | component:link-to',
132-
'ember.component.render | component:slow-loading-list',
133-
'ember.component.render | component:slow-loading-list',
134-
'ember.runloop.render | undefined',
135-
'ember.runloop.afterRender | undefined',
136-
'ember.runloop.destroy | undefined',
129+
'ui.ember.runloop.routerTransitions | undefined',
130+
'ui.ember.component.render | component:link-to',
131+
'ui.ember.component.render | component:link-to',
132+
'ui.ember.component.render | component:slow-loading-list',
133+
'ui.ember.component.render | component:slow-loading-list',
134+
'ui.ember.runloop.render | undefined',
135+
'ui.ember.runloop.afterRender | undefined',
136+
'ui.ember.runloop.destroy | undefined',
137137
],
138138
transaction: 'route:slow-loading-route.index',
139139
durationCheck: duration => duration > SLOW_TRANSITION_WAIT,

0 commit comments

Comments
 (0)