Skip to content

fix(tracing): Treat HTTP status code below 100 as UnknownError. #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

fix(tracing): Treat HTTP status code below 100 as UnknownError. #4131

merged 1 commit into from
Dec 3, 2021

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Nov 8, 2021

Fixes: #4058

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.45 KB (0%)
@sentry/browser - Webpack 23.35 KB (0%)
@sentry/react - Webpack 23.38 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.89 KB (+0.02% 🔺)

@AbhiPrasad AbhiPrasad merged commit fcf9431 into master Dec 3, 2021
@AbhiPrasad AbhiPrasad deleted the onur/http-ok-codes branch December 3, 2021 15:33
onurtemizkan added a commit that referenced this pull request Dec 19, 2021
@onurtemizkan
fix(tracing): Treat HTTP status code below 100 as UnknownError. (#4131
b577645 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sentry deciphers HTTP status code 0 as "OK"

4 participants

@onurtemizkan @iker-barriocanal @AbhiPrasad