File tree Expand file tree Collapse file tree 2 files changed +9
-1
lines changed Expand file tree Collapse file tree 2 files changed +9
-1
lines changed Original file line number Diff line number Diff line change @@ -46,7 +46,7 @@ export namespace SpanStatus {
4646 * @returns The span status or {@link SpanStatus.UnknownError}.
4747 */
4848 export function fromHttpCode ( httpStatus : number ) : SpanStatus {
49- if ( httpStatus < 400 ) {
49+ if ( httpStatus < 400 && httpStatus >= 100 ) {
5050 return SpanStatus . Ok ;
5151 }
5252
Original file line number Diff line number Diff line change @@ -90,6 +90,14 @@ describe('Span', () => {
9090 expect ( span . isSuccess ( ) ) . toBe ( true ) ;
9191 span . setStatus ( SpanStatus . PermissionDenied ) ;
9292 expect ( span . isSuccess ( ) ) . toBe ( false ) ;
93+ span . setHttpStatus ( 0 ) ;
94+ expect ( span . isSuccess ( ) ) . toBe ( false ) ;
95+ span . setHttpStatus ( - 1 ) ;
96+ expect ( span . isSuccess ( ) ) . toBe ( false ) ;
97+ span . setHttpStatus ( 99 ) ;
98+ expect ( span . isSuccess ( ) ) . toBe ( false ) ;
99+ span . setHttpStatus ( 100 ) ;
100+ expect ( span . isSuccess ( ) ) . toBe ( true ) ;
93101 } ) ;
94102 } ) ;
95103
You can’t perform that action at this time.
0 commit comments