Skip to content

test: Fix flaky onunhandledrejection tests #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021
Merged

test: Fix flaky onunhandledrejection tests #3482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions packages/node/test/onunhandledrejection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,29 @@
import { Hub, init, Integrations, Scope } from '../src';
import { Scope } from '@sentry/core';
import { Hub } from '@sentry/hub';
Comment on lines +1 to +2
Copy link
Contributor

@rhcarvalho rhcarvalho Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my learning -- Does changing this import affect the test, or is it just cosmetic/preference?

Copy link
Contributor Author

@kamilogorek kamilogorek Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic preference


const dsn = 'https://[email protected]/4291';
import { OnUnhandledRejection } from '../src/integrations/onunhandledrejection';

jest.mock('@sentry/hub', () => {
// we just want to short-circuit it, so dont worry about types
Copy link
Contributor

@rhcarvalho rhcarvalho Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the rest of the change, don't fully understand this.

Why do we want to short-circuit?

Copy link
Contributor Author

@kamilogorek kamilogorek Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because setupOnce is checking whether an integration is installed, which in the case of these tests should always be the case. I think this was the reason for flakyness, because hub is attached to the global object.

const original = jest.requireActual('@sentry/hub');
original.Hub.prototype.getIntegration = () => true;
return {
...original,
getCurrentHub: () => new Hub(),
};
});

describe('unhandled promises', () => {
test('install global listener', () => {
init({ dsn });
const integration = new OnUnhandledRejection();
integration.setupOnce();
expect(process.listeners('unhandledRejection')).toHaveLength(1);
});

test('sendUnhandledPromise', () => {
const integration = new Integrations.OnUnhandledRejection();
const integration = new OnUnhandledRejection();
integration.setupOnce();

const promise = {
domain: {
sentryContext: {
Expand Down