test: Fix flaky onunhandledrejection tests #3482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
requested review from
a team,
ahmedetefy and
iker-barriocanal
and removed request for
a team
Contributor
size-limit report
|
rhcarvalho
reviewed
Apr 29, 2021
Contributor
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
Do we have examples of the flakiness in CI (to document in the PR description)?
| import { OnUnhandledRejection } from '../src/integrations/onunhandledrejection'; | ||
|
|
||
| jest.mock('@sentry/hub', () => { | ||
| // we just want to short-circuit it, so dont worry about types |
Contributor
There was a problem hiding this comment.
I understand the rest of the change, don't fully understand this.
Why do we want to short-circuit?
Contributor
Author
There was a problem hiding this comment.
Because setupOnce is checking whether an integration is installed, which in the case of these tests should always be the case. I think this was the reason for flakyness, because hub is attached to the global object.
rhcarvalho
reviewed
Apr 29, 2021
Comment on lines
+1
to
+2
| import { Scope } from '@sentry/core'; | ||
| import { Hub } from '@sentry/hub'; |
Contributor
There was a problem hiding this comment.
For my learning -- Does changing this import affect the test, or is it just cosmetic/preference?
Contributor
Author
There was a problem hiding this comment.
Cosmetic preference
Contributor
Author
|
Linked an example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example failed test: https://github.com/getsentry/sentry-javascript/runs/2457635380