Skip to content

fix(types): make requestHandler options an own type #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

fix(types): make requestHandler options an own type #2995

merged 1 commit into from
Oct 27, 2020

Conversation

@rchl
Copy link
Contributor

@rchl rchl commented Oct 23, 2020

Resolves #2994

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@rchl rchl requested a review from kamilogorek as a code owner October 23, 2020 12:58
@kamilogorek kamilogorek merged commit c88499f into getsentry:master Oct 27, 2020
@kamilogorek
Copy link
Contributor

kamilogorek commented Oct 27, 2020

Thanks!

@rchl rchl deleted the patch-1 branch October 27, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kamilogorek kamilogorek kamilogorek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose type with combined "ParseRequestOptions" and "flushTimeout"

2 participants

@rchl @kamilogorek