-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Description
The requestHandler can be passed various options and currently the types for those options are defined as an union of types ParseRequestOptions & { flushTimeout?: number; }:
sentry-javascript/packages/node/src/handlers.ts
Lines 249 to 252 in a0b636b
| export function requestHandler( | |
| options?: ParseRequestOptions & { | |
| flushTimeout?: number; | |
| }, |
The issue is that the combined type is not exported so libraries that provide a higher-level configuration on top of Sentry can't import and use that type directly but have to create a similar union of types. And that can get out of sync with Sentry implementation.
The suggestion is to just create a separate type for this union so that it's exported from the module and can be used directly.
Metadata
Metadata
Assignees
Labels
No labels