fix(build): Pin @cloudflare/workers-types and unstale yarn.lock
#15564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Mar 4, 2025
|
semver from hell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15554 I forgot to update
yarn.lockand after doing that manually, I could reproduce a build error I got in CI. Turns out installing some version of4.202502...introduced a type-breaking change (I'm utterly confused by this versioning scheme, ngl). So I hard-pinned to4.20240725.0, which was close to the version we installed before (4.20240722.0) and still satisfied the same minimum devDep version.