fix(cloudflare): Make @cloudflare/workers-types an optional peer dependency
#15554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Mar 3, 2025
s1gr1d
approved these changes
Mar 3, 2025
This was referenced Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redeclares the
@cloudflare/workers-typespackage as an optional peer dependency rather than an optional dependency. With other SDKs now depending on@sentry/cloudflare, we'd pull in the type package into non-cloudflare projects. In the particular case reported in #15536, this lead to global type definitions offetchbeing overridden by the cloudflare types package (more details: #15536 (comment)).I'm not sure if I'm missing something but since we only use the
@cloudflare/workers-typesfor types, I think it's okay to make this an optional peer dependency. Which should avoid "polluting" non-CF projects with CF types.closes #15536