Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented May 10, 2024

No description provided.

ryan953 and others added 12 commits May 8, 2024 09:19
Before submitting a pull request, please take a look at our

[Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md)
guidelines and verify:

- [ ] If you've added code that should be tested, please add tests.
- [ ] Ensure your code lints and the test suite passes (`yarn lint`) &
(`yarn test`).
…1953)

Adding some missing labels that users will need access to if they want
to do translations. Also took the chance to rename a few to better align
with the other labels, and with their use.
The `type="email"` textbox enables some basic browser settings like
validating that the input looks like an email address, and will change
the keyboard to make it easier for phone users to type their info into
the box.
[Gitflow] Merge master into develop
We can simplify the function params and only pass options around most of
the time.

I also moved some dialog specific css variables into dialog.css.ts so
they can be async loaded, which depends on the options config.

Before submitting a pull request, please take a look at our

[Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md)
guidelines and verify:

- [ ] If you've added code that should be tested, please add tests.
- [ ] Ensure your code lints and the test suite passes (`yarn lint`) &
(`yarn test`).
This updates the CSS theme, variable names and also how the css works.
The widget is better able to handle cases like:
- short desktop window (scrolls form)
- phone in portrait (full width if the screen is 600px or less)
- phone in landscape (scrolls form)
- when screenshots are in use, stick to screen edges

I also made it, I think, easier to position the button (aka trigger, aka
actor) around the screen. You can override in css `--page-margin: 16px`
to dictate the distance from the edge, and override `--inset: auto 0 0
auto;` to position the button in the different corners of the screen.
For example, you can put the trigger button on the edge of the screen
with something like:
```css
#sentry-feedback {
  --actor-inset: auto 0 calc(50% - var(--header-height)) auto;
}
```

Docs are updated in getsentry/sentry-docs#9961
to reflect the changed config/variable names too.

Some samples of different situations:
| Desc | Img |
| --- | --- |
| Normal |
![normal](https://github.com/getsentry/sentry-javascript/assets/187460/9223cf1f-9b4b-4bdc-b35a-65ccded71540)
| Short Window | ![short
window](https://github.com/getsentry/sentry-javascript/assets/187460/5749a07a-ccb6-4c3c-909e-712cf5172f11)
| Screenshot editor |
![screenshot](https://github.com/getsentry/sentry-javascript/assets/187460/3a3bbbd0-c982-4d23-b0cf-d6f96ad2a7d1)
| Mobile landscape | ![mobile
landscape](https://github.com/getsentry/sentry-javascript/assets/187460/aee7ca1f-c6a1-4555-9b07-0ff75aad93e2)
| Mobile portrait | ![mobile
portrait](https://github.com/getsentry/sentry-javascript/assets/187460/c7c08261-8343-4498-9084-5432c6f1c60e)
| Override Color | ![colors
override](https://github.com/getsentry/sentry-javascript/assets/187460/99d2ae92-58a0-49f0-982c-95b3e312a694)
Add support for global onUnhandled Error/Promise for Bun.

```javascript
import * as Sentry from "@sentry/bun";

Sentry.init({
    dsn: "DSN",
});

console.log("Hello via Bun!");

throw new Error('Unhandled Bun Sentry Error!');
```

<img width="1063" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/363802/fd90969f-82a4-4300-a67e-1ebb5cf540fa">

ref: oven-sh/bun#5091
…rent span (#11974)

We introduced sending standalone `http.client` spans in
#11783. Subsequently,
we had to revert this change due to internal timeline problems (😢).
However, in the revert PR (#11879) we missed that originally, we checked
for an active parent span and only then created an `http.client` span.
The result were `http.client` _transactions_ which we also don't want.
This patch fixes that by re-introducing the `hasParent` check as it was
pre-#11783.
Fix the `files` property in our AWS Serverless SDK
`package.json` to include ESM artifacts now that we support ESM in AWS
Serverless.
@lforst lforst requested a review from Lms24 May 10, 2024 14:07
@lforst lforst changed the base branch from develop to master May 10, 2024 14:08
@lforst lforst requested a review from a team as a code owner May 10, 2024 14:08
@lforst lforst merged commit 7a8fe99 into master May 10, 2024
@lforst lforst deleted the prepare-release/8.0.0-rc.3 branch May 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants