-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
meta(changelog): Update changelog for 8.0.0-rc.3 #11976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`).
…1953) Adding some missing labels that users will need access to if they want to do translations. Also took the chance to rename a few to better align with the other labels, and with their use.
The `type="email"` textbox enables some basic browser settings like validating that the input looks like an email address, and will change the keyboard to make it easier for phone users to type their info into the box.
[Gitflow] Merge master into develop
We can simplify the function params and only pass options around most of the time. I also moved some dialog specific css variables into dialog.css.ts so they can be async loaded, which depends on the options config. Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`).
This updates the CSS theme, variable names and also how the css works.
The widget is better able to handle cases like:
- short desktop window (scrolls form)
- phone in portrait (full width if the screen is 600px or less)
- phone in landscape (scrolls form)
- when screenshots are in use, stick to screen edges
I also made it, I think, easier to position the button (aka trigger, aka
actor) around the screen. You can override in css `--page-margin: 16px`
to dictate the distance from the edge, and override `--inset: auto 0 0
auto;` to position the button in the different corners of the screen.
For example, you can put the trigger button on the edge of the screen
with something like:
```css
#sentry-feedback {
--actor-inset: auto 0 calc(50% - var(--header-height)) auto;
}
```
Docs are updated in getsentry/sentry-docs#9961
to reflect the changed config/variable names too.
Some samples of different situations:
| Desc | Img |
| --- | --- |
| Normal |

| Short Window | 
| Screenshot editor |

| Mobile landscape | 
| Mobile portrait | 
| Override Color | 
Add support for global onUnhandled Error/Promise for Bun.
```javascript
import * as Sentry from "@sentry/bun";
Sentry.init({
dsn: "DSN",
});
console.log("Hello via Bun!");
throw new Error('Unhandled Bun Sentry Error!');
```
<img width="1063" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/363802/fd90969f-82a4-4300-a67e-1ebb5cf540fa">
ref: oven-sh/bun#5091
…rent span (#11974) We introduced sending standalone `http.client` spans in #11783. Subsequently, we had to revert this change due to internal timeline problems (😢). However, in the revert PR (#11879) we missed that originally, we checked for an active parent span and only then created an `http.client` span. The result were `http.client` _transactions_ which we also don't want. This patch fixes that by re-introducing the `hasParent` check as it was pre-#11783.
Fix the `files` property in our AWS Serverless SDK `package.json` to include ESM artifacts now that we support ESM in AWS Serverless.
Lms24
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.