Skip to content

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented May 8, 2024

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@ryan953 ryan953 requested a review from a team as a code owner May 8, 2024 14:28
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (0%)
@sentry/browser (incl. Tracing) 32.68 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.02 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.42 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.06 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.15 KB (+0.01% 🔺)
@sentry/browser (incl. Feedback) 37.66 KB (+0.01% 🔺)
@sentry/browser (incl. sendFeedback) 26.21 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.84 KB (+0.01% 🔺)
@sentry/react 24.33 KB (0%)
@sentry/react (incl. Tracing) 35.64 KB (0%)
@sentry/vue 25.48 KB (0%)
@sentry/vue (incl. Tracing) 34.47 KB (0%)
@sentry/svelte 21.78 KB (0%)
CDN Bundle 24.13 KB (0%)
CDN Bundle (incl. Tracing) 34.05 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.72 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.93 KB (+0.01% 🔺)
CDN Bundle - uncompressed 70.99 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.61 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.9 KB (+0.01% 🔺)
@sentry/nextjs (client) 34.87 KB (0%)
@sentry/sveltekit (client) 33.24 KB (0%)
@sentry/node 147.35 KB (-0.01% 🔽)

@ryan953 ryan953 marked this pull request as draft May 8, 2024 15:02
@ryan953 ryan953 force-pushed the ryan953/ref-feedback-config branch from 7397f55 to b5d5606 Compare May 8, 2024 15:10
@ryan953 ryan953 changed the title Ryan953/ref feedback config ref(feedback): Rename showScreenshot config to enableScreenshot May 8, 2024
@ryan953 ryan953 marked this pull request as ready for review May 8, 2024 15:11
Copy link
Contributor

@c298lee c298lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ryan953 ryan953 merged commit fd7a44b into develop May 8, 2024
@ryan953 ryan953 deleted the ryan953/ref-feedback-config branch May 8, 2024 16:19
andreiborza pushed a commit that referenced this pull request May 16, 2024
Before submitting a pull request, please take a look at our

[Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md)
guidelines and verify:

- [ ] If you've added code that should be tested, please add tests.
- [ ] Ensure your code lints and the test suite passes (`yarn lint`) &
(`yarn test`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants