Skip to content

ref(feedback): Rename showScreenshot config to enableScreenshot #11952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

ref(feedback): Rename showScreenshot config to enableScreenshot #11952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/feedback/src/core/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const buildFeedbackIntegration = ({
autoInject = true,
showEmail = true,
showName = true,
showScreenshot = true,
enableScreenshot = true,
useSentryUser = {
email: 'email',
name: 'username',
Expand Down Expand Up @@ -108,7 +108,7 @@ export const buildFeedbackIntegration = ({
isNameRequired,
showEmail,
showName,
showScreenshot,
enableScreenshot,
useSentryUser,

colorScheme,
Expand Down Expand Up @@ -176,7 +176,7 @@ export const buildFeedbackIntegration = ({
};

const _loadAndRenderDialog = async (options: FeedbackInternalOptions): Promise<FeedbackDialog> => {
const screenshotRequired = options.showScreenshot && isScreenshotSupported();
const screenshotRequired = options.enableScreenshot && isScreenshotSupported();
const [modalIntegration, screenshotIntegration] = await Promise.all([
_findIntegration<FeedbackModalIntegration>('FeedbackModal', getModalIntegration, 'feedbackModalIntegration'),
screenshotRequired
Expand Down
2 changes: 1 addition & 1 deletion packages/types/src/feedback/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export interface FeedbackGeneralConfiguration {
* Should the screen shots field be included?
* Screen shots cannot be marked as required
*/
showScreenshot: boolean;
enableScreenshot: boolean;

/**
* Fill in email/name input fields with Sentry user context if it exists.
Expand Down