Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented May 8, 2024

No description provided.

github-actions bot and others added 14 commits May 7, 2024 07:15
[Gitflow] Merge master into develop
This prints a warning if we detect that the koa app passed to
setupKoaErrorHandler is not instrumented.
This happens if you import koa before calling Sentry.init.
This prints a warning if we detect that the express `app` passed to
`setupExpressErrorHandler` is not instrumented.
This happens if you import express _before_ calling Sentry.init:

<img width="877" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/2411343/1af41fb9-06f5-4478-8be0-72c46568da14">
The user can be set on any scope, we should pick it correctly from
wherever it is set.
When using `setupFastifyErrorHandler(app)` we can check if the app was
correctly instrumented.

Not sure how to best test this - I tested this manually in a test app
and could verify that the log was printed when requiring fastify before
calling init!
No need to have the `-app` suffix there.
Closes #11766 

These tests are also in TypeScript so they check the types too.

I found that two out of three cron libraries were actually swallowing
exceptions so that they were not captured by Sentry. I added calls to
`captureException` to rectify that.
Use vitest instead of jest. Some notes:

* Use vi/jest `*Async` fake timer functions instead of
`process.nextTick`
* Our `useFakeTimers` module was setting an interval which was causing
all sorts of flakes in tests with the updated fake timers library
* removed the interval in `use-fake-timers` module which seemed to be
unnecessary and was causing lots of flakes in our tests (also was able
to remove all of the random tick values in timestamps due to this)
@lforst lforst requested review from a team as code owners May 8, 2024 13:15
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (added)
@sentry/browser (incl. Tracing) 32.68 KB (added)
@sentry/browser (incl. Tracing, Replay) 68.02 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.42 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.06 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.15 KB (added)
@sentry/browser (incl. Feedback) 37.66 KB (added)
@sentry/browser (incl. sendFeedback) 26.21 KB (added)
@sentry/browser (incl. FeedbackAsync) 30.84 KB (added)
@sentry/react 24.33 KB (added)
@sentry/react (incl. Tracing) 35.64 KB (added)
@sentry/vue 25.48 KB (added)
@sentry/vue (incl. Tracing) 34.47 KB (added)
@sentry/svelte 21.78 KB (added)
CDN Bundle 24.13 KB (added)
CDN Bundle (incl. Tracing) 34.05 KB (added)
CDN Bundle (incl. Tracing, Replay) 67.72 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.93 KB (added)
CDN Bundle - uncompressed 70.99 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 101 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.61 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.89 KB (added)
@sentry/nextjs (client) 34.87 KB (added)
@sentry/sveltekit (client) 33.24 KB (added)
@sentry/node 147.35 KB (added)

@lforst lforst merged commit 57bef20 into master May 8, 2024
@lforst lforst deleted the prepare-release/8.0.0-rc.2 branch May 8, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants