Skip to content

test: Streamline E2E test app names #11828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

test: Streamline E2E test app names #11828

merged 1 commit into from
May 7, 2024

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 29, 2024 •
edited
Loading

No need to have the -app suffix there.

@mydea mydea requested review from lforst and s1gr1d April 29, 2024 11:44
@mydea mydea self-assigned this Apr 29, 2024
s1gr1d
s1gr1d approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@mydea mydea force-pushed the fn/streamline-e2e-names branch from 4b1e1f3 to 97813ed Compare May 6, 2024 09:49
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (0%)
@sentry/browser (incl. Tracing) 32.68 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) 68.02 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.42 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.06 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.15 KB (+0.02% 🔺)
@sentry/browser (incl. Feedback) 37.66 KB (0%)
@sentry/browser (incl. sendFeedback) 26.21 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.84 KB (0%)
@sentry/react 24.33 KB (0%)
@sentry/react (incl. Tracing) 35.64 KB (+0.02% 🔺)
@sentry/vue 25.48 KB (0%)
@sentry/vue (incl. Tracing) 34.47 KB (+0.03% 🔺)
@sentry/svelte 21.78 KB (0%)
CDN Bundle 24.13 KB (0%)
CDN Bundle (incl. Tracing) 34.05 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay) 67.72 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.93 KB (+0.02% 🔺)
CDN Bundle - uncompressed 70.99 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101 KB (+0.03% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.61 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.89 KB (+0.01% 🔺)
@sentry/nextjs (client) 34.87 KB (+0.03% 🔺)
@sentry/sveltekit (client) 33.24 KB (+0.03% 🔺)
@sentry/node 146.27 KB (-0.01% 🔽)

@mydea
test: Streamline E2E test app names
75b7b90 
No need to have the `-app` suffix there.
@mydea mydea force-pushed the fn/streamline-e2e-names branch from 97813ed to 75b7b90 Compare May 7, 2024 14:34
@mydea mydea enabled auto-merge (squash) May 7, 2024 14:59
@mydea mydea merged commit 31d462e into develop May 7, 2024
@mydea mydea deleted the fn/streamline-e2e-names branch May 7, 2024 14:59
andreiborza pushed a commit that referenced this pull request May 16, 2024
@mydea @andreiborza
test: Streamline E2E test app names (#11828)
0d32bf8 
No need to have the `-app` suffix there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1gr1d s1gr1d s1gr1d approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @s1gr1d