Skip to content

Commit 4b1e1f3

Browse files
committed
test: Streamline E2E test app names
No need to have the `-app` suffix there.
1 parent 7759d18 commit 4b1e1f3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+71
-72
lines changed

.github/workflows/build.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -993,7 +993,7 @@ jobs:
993993
[
994994
'angular-17',
995995
'cloudflare-astro',
996-
'node-express-app',
996+
'node-express',
997997
'create-react-app',
998998
'create-next-app',
999999
'create-remix-app',
@@ -1012,13 +1012,12 @@ jobs:
10121012
'sveltekit-2',
10131013
'sveltekit-2-svelte-5',
10141014
'generic-ts3.8',
1015-
'node-fastify-app',
1016-
# TODO(v8): Re-enable hapi tests
1017-
# 'node-hapi-app',
1018-
'node-nestjs-app',
1015+
'node-fastify',
1016+
'node-hapi',
1017+
'node-nestjs',
10191018
'node-exports-test-app',
1020-
'node-koa-app',
1021-
'node-connect-app',
1019+
'node-koa',
1020+
'node-connect',
10221021
'vue-3',
10231022
'webpack-4',
10241023
'webpack-5'

dev-packages/e2e-tests/test-applications/node-connect-app/start-event-proxy.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.

dev-packages/e2e-tests/test-applications/node-connect-app/package.json renamed to dev-packages/e2e-tests/test-applications/node-connect/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "node-connect-app",
2+
"name": "node-connect",
33
"version": "1.0.0",
44
"private": true,
55
"scripts": {

dev-packages/e2e-tests/test-applications/node-koa-app/start-event-proxy.ts renamed to dev-packages/e2e-tests/test-applications/node-connect/start-event-proxy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/event-proxy-server';
22

33
startEventProxyServer({
44
port: 3031,
5-
proxyServerName: 'node-koa-app',
5+
proxyServerName: 'node-connect',
66
});

dev-packages/e2e-tests/test-applications/node-connect-app/tests/errors.test.ts renamed to dev-packages/e2e-tests/test-applications/node-connect/tests/errors.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ test('Sends exception to Sentry', async ({ baseURL }) => {
4040
});
4141

4242
test('Sends correct error event', async ({ baseURL }) => {
43-
const errorEventPromise = waitForError('node-connect-app', event => {
43+
const errorEventPromise = waitForError('node-connect', event => {
4444
return !event.type && event.exception?.values?.[0]?.value === 'This is an exception';
4545
});
4646

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const sentryTestProject = process.env.E2E_TEST_SENTRY_TEST_PROJECT;
88
const EVENT_POLLING_TIMEOUT = 90_000;
99

1010
test('Sends an API route transaction', async ({ baseURL }) => {
11-
const pageloadTransactionEventPromise = waitForTransaction('node-connect-app', transactionEvent => {
11+
const pageloadTransactionEventPromise = waitForTransaction('node-connect', transactionEvent => {
1212
return (
1313
transactionEvent?.contexts?.trace?.op === 'http.server' &&
1414
transactionEvent?.transaction === 'GET /test-transaction'

0 commit comments

Comments
 (0)