Skip to content

fix(node): Ensure DSC is correctly set in envelope headers #11628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix(node): Ensure DSC is correctly set in envelope headers #11628

merged 2 commits into from
Apr 16, 2024

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 16, 2024 •
edited
Loading

This was not correctly set before when we had an active span - the error-active-span & error-active-span-unsampled scenarios failed before and had no trace set on the envelope headers.

The fix was to actually fix our setupEventContextTrace utility for OTEL, where we now just set the dsc on the event sdkProcessingMetadata, which is picked up when event processing. I also moved this to preprocessEvent to ensure this runs before other stuff.

This should fix https://github.com/getsentry/sentry-javascript-examples/pull/7/files#r1561220216 which @s1gr1d found in her example app. 🚀

@mydea mydea requested review from AbhiPrasad and Lms24 April 16, 2024 13:38
@mydea mydea self-assigned this Apr 16, 2024
@mydea mydea requested a review from s1gr1d April 16, 2024 13:38
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.16 KB (0%)
@sentry/browser (incl. Tracing) 31.77 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.08 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.9 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.79 KB (0%)
@sentry/browser (incl. Feedback) 35.71 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.71 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.74 KB (0%)
@sentry/browser (incl. sendFeedback) 26.95 KB (0%)
@sentry/react 24.84 KB (0%)
@sentry/react (incl. Tracing) 34.66 KB (0%)
@sentry/vue 25.72 KB (0%)
@sentry/vue (incl. Tracing) 33.48 KB (0%)
@sentry/svelte 22.28 KB (0%)
CDN Bundle 24.47 KB (0%)
CDN Bundle (incl. Tracing) 32.99 KB (0%)
CDN Bundle (incl. Tracing, Replay) 66.6 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.81 KB (0%)
CDN Bundle - uncompressed 72.9 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 99.01 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 208.67 KB (0%)
@sentry/nextjs (client) 34.03 KB (0%)
@sentry/sveltekit (client) 32.26 KB (0%)
@sentry/node 124.68 KB (+0.03% 🔺)

@mydea mydea merged commit 379a9e5 into develop Apr 16, 2024
@mydea mydea deleted the fn/node-envelope-header branch April 16, 2024 14:34
@s1gr1d s1gr1d mentioned this pull request Apr 16, 2024
Closed
@mydea mydea mentioned this pull request Apr 18, 2024
Merged
mydea added a commit that referenced this pull request Apr 18, 2024
@mydea
fix(node): Ensure DSC on envelope header uses root span (#11683)
a07377e 
Fixes an oversight from
#11628, which was
found in the example app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @Lms24 @AbhiPrasad