feat(browser): Bump web-vitals to 3.5.2 #11391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
timfish
reviewed
Apr 3, 2024
timfish
reviewed
Apr 3, 2024
packages/tracing-internal/src/browser/web-vitals/lib/getVisibilityWatcher.ts
Outdated
Show resolved
Hide resolved
|
I removed the polyfill, now it is just a small increase! |
AbhiPrasad
approved these changes
Apr 3, 2024
mydea
commented
Apr 4, 2024
| import type { MetricRatingThresholds, ReportOpts, TTFBReportCallback } from './types'; | ||
|
|
||
| /** Thresholds for TTFB. See https://web.dev/articles/ttfb#what_is_a_good_ttfb_score */ | ||
| // NOTE (Sentry): We use a lower threshold here than web-vitals, which uses [800, 1800] |
There was a problem hiding this comment.
Note to self: I lowered this so tests would pass etc. Not sure if it makes sense to not capture this when lower than 800 🤷 we can revisit this later.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
There are some bug fixes in the meanwhile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some bug fixes in the meanwhile.