Skip to content

Commit d347293

Browse files
committed
fix flaky test
1 parent 4f01446 commit d347293

File tree

1 file changed

+10
-3
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb

1 file changed

+10
-3
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb/test.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,22 @@ import type { Event } from '@sentry/types';
44
import { sentryTest } from '../../../../utils/fixtures';
55
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
66

7-
sentryTest('should capture TTFB vital.', async ({ getLocalTestPath, page }) => {
7+
sentryTest('should capture TTFB vital.', async ({ getLocalTestUrl, page }) => {
88
if (shouldSkipTracingTest()) {
99
sentryTest.skip();
1010
}
1111

12-
const url = await getLocalTestPath({ testDir: __dirname });
12+
const url = await getLocalTestUrl({ testDir: __dirname });
1313
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
1414

1515
expect(eventData.measurements).toBeDefined();
16-
expect(eventData.measurements?.ttfb?.value).toBeDefined();
16+
17+
// If responseStart === 0, ttfb is not reported
18+
// This seems to happen somewhat randomly, so we just ignore this in that case
19+
const responseStart = await page.evaluate("performance.getEntriesByType('navigation')[0].responseStart;");
20+
if (responseStart !== 0) {
21+
expect(eventData.measurements?.ttfb?.value).toBeDefined();
22+
}
23+
1724
expect(eventData.measurements?.['ttfb.requestTime']?.value).toBeDefined();
1825
});

0 commit comments

Comments
 (0)