test(node): Add prisma OpenTelemetry integration tests. #10778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/prisma-otel-integration-tests
branch
2 times, most recently
from
fc9d3a9 to
9761634
Compare
Lms24
reviewed
Feb 22, 2024
Comment on lines
+6
to
+13
| if (NODE_VERSION.major && NODE_VERSION.major < 16) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn(`Skipping Prisma tests on Node: ${NODE_VERSION.major}`); | ||
| process.exit(0); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Does prisma only support Node 16+? (If so, can we add a comment that this is the reason why we skip?
Collaborator
Author
There was a problem hiding this comment.
Yes, I just added a comment with the link 👍
onurtemizkan
force-pushed
the
onur/prisma-otel-integration-tests
branch
from
0ca9edd to
4c63dec
Compare
Lms24
approved these changes
Feb 22, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Despite my comment, I think we can merge the PR as it is right now. If the origin should be something else than 'manual' we can (and should) adjust it and the tests in a follow up PR.
| model: 'User', | ||
| name: 'User.create', | ||
| 'otel.kind': 'INTERNAL', | ||
| 'sentry.origin': 'manual', |
Member
There was a problem hiding this comment.
hmm not a hard blocker to merge the tests but @mydea is it expected that the spans all have 'sentry.origin': 'manual'? Maybe this is an otel<>sentry limitation I'm not aware of.
Member
There was a problem hiding this comment.
It's because sentry.origin is the default, I think this is fine to leave for now and we re-evaluate closer to v8 release.
AbhiPrasad
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #10483 which I closed by mistake.
Part of #9907