test(node): Add prisma OpenTelemetry integration tests.
#10483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/prisma-otel-integration-tests
branch
from
9c0c3f7 to
839a3be
Compare
Contributor
size-limit report 📦
|
mydea
reviewed
Feb 5, 2024
| "clean:docker": "node scripts/clean.js", | ||
| "prisma:init": "(cd suites/tracing/prisma-orm && ts-node ./setup.ts)", | ||
| "prisma:init:new": "(cd suites/tracing-new/prisma-orm && ts-node ./setup.ts)", | ||
| "prisma:init:experimental": "(cd suites/tracing-experimental/prisma-orm && ts-node ./setup.ts)", |
Member
There was a problem hiding this comment.
Just thinking, would it not be possible to re-use the same prisma instance for the node-experimental test? I don't really know the specifics of this, though, so 😅
Collaborator
Author
There was a problem hiding this comment.
I think so, but we need to update that one Prisma version to latest, which should be fine IMO anyway. Should I do that?
Member
There was a problem hiding this comment.
I think yes, let's do that! Makes sense to test against 5.x here anyhow!
Collaborator
Author
There was a problem hiding this comment.
@mydea, I tried but could not make this work with the same instance. I have updated all the versions to 5 though.
onurtemizkan
force-pushed
the
onur/prisma-otel-integration-tests
branch
7 times, most recently
from
3582ac7 to
478e91b
Compare
AbhiPrasad
approved these changes
Feb 20, 2024
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
If you rebase this we can merge it in @onurtemizkan!
onurtemizkan
force-pushed
the
onur/prisma-otel-integration-tests
branch
from
478e91b to
e80313e
Compare
onurtemizkan
force-pushed
the
onur/prisma-otel-integration-tests
branch
from
20e23c7 to
dd36a9c
Compare
Collaborator
Author
|
@AbhiPrasad, I closed this by mistake. Opened #10778 from the same branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9907