Skip to content

Conversation

@AbhiPrasad
Copy link
Member

ref #10677

Removes all usage of setting/getting span.description and span.name, and removes the span.setName method.

@AbhiPrasad AbhiPrasad requested a review from a team February 16, 2024 20:01
@AbhiPrasad AbhiPrasad self-assigned this Feb 16, 2024
@AbhiPrasad AbhiPrasad requested review from lforst and stephanie-anderson and removed request for a team February 16, 2024 20:01
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.8 KB (-0.14% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.05 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.98 KB (-0.15% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.61 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (-0.29% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.16 KB (-0.26% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.15 KB (-0.12% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.15 KB (-0.13% 🔽)
@sentry/browser - Webpack (gzipped) 22.41 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.13 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.62 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.59 KB (-0.28% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.76 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.67 KB (-0.24% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.39 KB (-0.41% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.2 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.87 KB (-0.27% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.35 KB (-0.17% 🔽)
@sentry/react - Webpack (gzipped) 22.45 KB (-0.1% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.87 KB (-0.13% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.08 KB (-0.17% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.16 KB (0%)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 20, 2024 19:01
@AbhiPrasad
Copy link
Member Author

I had to turn off hapi e2e tests because they kept flaking here. Put a todo for us to re-visit it (though it will be changed with v8 as well).

@AbhiPrasad AbhiPrasad merged commit c2baeac into develop Feb 21, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-span-name branch February 21, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants