fix background tab test

Author: AbhiPrasad

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/backgroundtab-custom/test.ts

@@ -23,23 +23,23 @@ sentryTest('should finish a custom transaction when the page goes background', a
   const transactionHandle = await page.evaluateHandle('window.transaction');
 
   const id_before = await getPropertyValue(transactionHandle, 'span_id');
-  const name_before = await getPropertyValue(transactionHandle, 'name');
+  const nameBefore = JSON.parse(await transactionHandle.evaluate((t: any) => JSON.stringify(t))).description;
   const status_before = await getPropertyValue(transactionHandle, 'status');
   const tags_before = await getPropertyValue(transactionHandle, 'tags');
 
-  expect(name_before).toBe('test-transaction');
+  expect(nameBefore).toBe('test-transaction');
   expect(status_before).toBeUndefined();
   expect(tags_before).toStrictEqual({});
 
   await page.locator('#go-background').click();
 
   const id_after = await getPropertyValue(transactionHandle, 'span_id');
-  const name_after = await getPropertyValue(transactionHandle, 'name');
+  const nameAfter = JSON.parse(await transactionHandle.evaluate((t: any) => JSON.stringify(t))).description;
   const status_after = await getPropertyValue(transactionHandle, 'status');
   const tags_after = await getPropertyValue(transactionHandle, 'tags');
 
   expect(id_before).toBe(id_after);
-  expect(name_after).toBe(name_before);
+  expect(nameAfter).toBe('test-transaction');
   expect(status_after).toBe('cancelled');
   expect(tags_after).toStrictEqual({ visibilitychange: 'document.hidden' });
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/pageloadWithHeartbeatTimeout/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import { spanToJSON } from '@sentry/core';
 import type { Event } from '@sentry/types';
 
 import { sentryTest } from '../../../../utils/fixtures';
@@ -20,8 +21,10 @@ sentryTest(
 
     expect(eventData.contexts?.trace?.op).toBe('pageload');
     expect(
-      // eslint-disable-next-line deprecation/deprecation
-      eventData.spans?.find(span => span.description === 'pageload-child-span' && span.status === 'cancelled'),
+      eventData.spans?.find(
+        // eslint-disable-next-line deprecation/deprecation
+        span => spanToJSON(span).description === 'pageload-child-span' && span.status === 'cancelled',
+      ),
     ).toBeDefined();
   },
 );

dev-packages/browser-integration-tests/suites/tracing/browsertracing/backgroundtab-custom/test.ts

@@ -23,23 +23,23 @@ sentryTest('should finish a custom transaction when the page goes background', a
   const transactionHandle = await page.evaluateHandle('window.transaction');
 
   const id_before = await getPropertyValue(transactionHandle, 'span_id');
-  const name_before = await getPropertyValue(transactionHandle, 'name');
+  const nameBefore = JSON.parse(await transactionHandle.evaluate((t: any) => JSON.stringify(t))).description;
   const status_before = await getPropertyValue(transactionHandle, 'status');
   const tags_before = await getPropertyValue(transactionHandle, 'tags');
 
-  expect(name_before).toBe('test-transaction');
+  expect(nameBefore).toBe('test-transaction');
   expect(status_before).toBeUndefined();
   expect(tags_before).toStrictEqual({});
 
   await page.locator('#go-background').click();
 
   const id_after = await getPropertyValue(transactionHandle, 'span_id');
-  const name_after = await getPropertyValue(transactionHandle, 'name');
+  const nameAfter = JSON.parse(await transactionHandle.evaluate((t: any) => JSON.stringify(t))).description;
   const status_after = await getPropertyValue(transactionHandle, 'status');
   const tags_after = await getPropertyValue(transactionHandle, 'tags');
 
   expect(id_before).toBe(id_after);
-  expect(name_after).toBe(name_before);
+  expect(nameAfter).toBe('test-transaction');
   expect(status_after).toBe('cancelled');
   expect(tags_after).toStrictEqual({ visibilitychange: 'document.hidden' });
 });

dev-packages/browser-integration-tests/suites/tracing/browsertracing/pageloadWithHeartbeatTimeout/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import { spanToJSON } from '@sentry/core';
 import type { Event } from '@sentry/types';
 
 import { sentryTest } from '../../../../utils/fixtures';
@@ -20,8 +21,10 @@ sentryTest(
 
     expect(eventData.contexts?.trace?.op).toBe('pageload');
     expect(
-      // eslint-disable-next-line deprecation/deprecation
-      eventData.spans?.find(span => span.description === 'pageload-child-span' && span.status === 'cancelled'),
+      eventData.spans?.find(
+        // eslint-disable-next-line deprecation/deprecation
+        span => spanToJSON(span).description === 'pageload-child-span' && span.status === 'cancelled',
+      ),
     ).toBeDefined();
   },
 );

packages/core/test/lib/tracing/trace.test.ts

@@ -105,7 +105,7 @@ describe('startSpan', () => {
       }
       expect(ref).toBeDefined();
 
-      expect(ref.name).toEqual('GET users/[id]');
+      expect(spanToJSON(ref).description).toEqual('GET users/[id]');
       expect(ref.status).toEqual(isError ? 'internal_error' : undefined);
     });
 
@@ -192,7 +192,7 @@ describe('startSpan', () => {
       }
 
       expect(ref.spanRecorder.spans).toHaveLength(2);
-      expect(ref.spanRecorder.spans[1].description).toEqual('SELECT * from users');
+      expect(spanToJSON(ref.spanRecorder.spans[1]).description).toEqual('SELECT * from users');
       expect(ref.spanRecorder.spans[1].parentSpanId).toEqual(ref.spanId);
       expect(ref.spanRecorder.spans[1].status).toEqual(isError ? 'internal_error' : undefined);
     });

packages/core/test/lib/tracing/transaction.test.ts

@@ -18,11 +18,12 @@ describe('transaction', () => {
       const transaction = new Transaction({ name: 'span name' });
       transaction.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
       expect(spanToJSON(transaction).description).toEqual('span name');
+      expect(spanToJSON(transaction).data?.[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]).toEqual('route');
 
       transaction.updateName('new name');
 
       expect(spanToJSON(transaction).description).toEqual('new name');
-      expect(transaction.metadata.source).toEqual('route');
+      expect(spanToJSON(transaction).data?.[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]).toEqual('custom');
     });
     /* eslint-enable deprecation/deprecation */
   });